Bug 235127 - [PATCH] deskutils/xfce4-notifyd: modernize and cleanup port
Summary: [PATCH] deskutils/xfce4-notifyd: modernize and cleanup port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-22 14:53 UTC by Guido Falsi
Modified: 2019-01-24 20:57 UTC (History)
0 users

See Also:
ehaupt: maintainer-feedback+


Attachments
patch (1.94 KB, patch)
2019-01-22 14:53 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2019-01-22 14:53:26 UTC
Created attachment 201331 [details]
patch

Hi,

I've committed a general cleanup and modernization patch for xfce ports in r490953.

I also made similar changes to deskutils/xfce4-notifyd.

In particular:

- Removed unneeded patch
- Added gnome USES
- Cosmetic changes, like sorting things and reflowing OPTIONS related parts

Can you approve this patch?

Thanks.
Comment 1 Emanuel Haupt freebsd_committer 2019-01-24 16:24:08 UTC
LGTM, please commit!
Comment 2 commit-hook freebsd_committer 2019-01-24 20:55:11 UTC
A commit references this bug:

Author: madpilot
Date: Thu Jan 24 20:54:16 UTC 2019
New revision: 491118
URL: https://svnweb.freebsd.org/changeset/ports/491118

Log:
  - Remove unneeded patch
  - Add USES=gnome
  - Sort USE_GNOME
  - Use CONFIGURE_ENABLE to cotrol NLS option
  - Some cosmetic changes

  PR:		235127
  Approved by:	ehaupt (maintainer)

Changes:
  head/deskutils/xfce4-notifyd/Makefile
  head/deskutils/xfce4-notifyd/files/
Comment 3 Guido Falsi freebsd_committer 2019-01-24 20:57:22 UTC
Committed. Thanks!