Bug 235128 - [PATCH] deskutils/xfce4-volumed: modernize and cleanup port
Summary: [PATCH] deskutils/xfce4-volumed: modernize and cleanup port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
Depends on:
Reported: 2019-01-22 14:55 UTC by Guido Falsi
Modified: 2019-01-22 18:51 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sergey.dyatko)

patch (961 bytes, patch)
2019-01-22 14:55 UTC, Guido Falsi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2019-01-22 14:55:49 UTC
Created attachment 201332 [details]


I've committed a general cleanup and modernization patch for xfce ports in r490953.

I also made similar changes to deskutils/xfce4-volumed.

In particular:

- Added missing dependencies
- Added USES=gnome
- Cosmetic changes, like sorting things and reflowing OPTIONS related parts

Can you approve this patch?

Comment 1 Sergey V. Dyatko 2019-01-22 16:15:27 UTC
Looks good to me
Comment 2 commit-hook freebsd_committer 2019-01-22 18:51:25 UTC
A commit references this bug:

Author: madpilot
Date: Tue Jan 22 18:50:45 UTC 2019
New revision: 490973
URL: https://svnweb.freebsd.org/changeset/ports/490973

  - Add missing dependencies
  - Sort lists
  - Fix portlint warnings

  PR:		235128
  Submitted by:	myself
  Approved by:	Sergey V. Dyatko <sergey.dyatko@gmail.com> (Maintainer)

Comment 3 Guido Falsi freebsd_committer 2019-01-22 18:51:33 UTC
Committed. Thanks!