Bug 235177 - audio/mumble: Add DEPRECATED notice for Qt4
Summary: audio/mumble: Add DEPRECATED notice for Qt4
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Mark Felder
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2019-01-24 12:58 UTC by gspu
Modified: 2019-03-21 22:19 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (feld)
koobs: merge-quarterly?


Attachments
mumble 1.3.0-rc1 (3.82 KB, application/x-gzip)
2019-03-21 00:00 UTC, Mark Felder
no flags Details
Mumble 1.3.0-r1 (3.75 KB, patch)
2019-03-21 01:56 UTC, VVD
no flags Details | Diff
Added support for Speech Dispatcher (1016 bytes, patch)
2019-03-21 19:37 UTC, VVD
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gspu 2019-01-24 12:58:47 UTC
Please change the Mumble-build to qt5 because:
DEPRECATED=             Qt4 has been EOL since december 2015
EXPIRATION_DATE=        2019-03-15
Comment 1 VVD 2019-03-18 12:12:17 UTC
1.3.0-rc1 was "released" yesterday: https://github.com/mumble-voip/mumble/issues/2728#issuecomment-473710939

Build fine for me on 12.0 amd64 (mumble and murmurd):
git clone --branch 1.3.0-rc1 https://github.com/mumble-voip/mumble.git mumble
cd mumble
git submodule init
git submodule update
qmake "CONFIG+=bundled-celt no-bundled-speex no-bundled-opus no-update bundled-rnnoise no-alsa no-jackaudio no-portaudio no-pulseaudio no-dbus no-bonjour no-ice" main.pro
gmake release

I made few "draft" of Makefile:
-PORTVERSION=   1.2.19
-PORTREVISION=  14
+PORTVERSION=   1.3.0.rc1
+PORTREVISION=  0

-USES=          compiler:c++11-lang cpe desktop-file-utils gmake pkgconfig qmake qt:4 ssl
+USES=          compiler:c++11-lang cpe desktop-file-utils gmake pkgconfig qmake qt:5 ssl

-GH_TAGNAME=    5a16cda:mumble_celt_0_7 e18de77:mumble_celt_0_11
+GH_TAGNAME=    1.3.0-rc1 5a16cda:mumble_celt_0_7 e18de77:mumble_celt_0_11

-USE_QT=                gui svg iconengines_run xml sql network l10n \
-               linguist_build moc_build rcc_build uic_build \
-               opengl sql-sqlite3_run corelib
+USE_QT=                gui svg xml sql network l10n linguist_build \
+               opengl sql-sqlite3_run core

-CONFIG=                no-server no-alsa no-speechd no-bundled-speex no-bundled-opus no-update \
-               bundled-celt no-g15 no-pulseaudio no-xevie no-embed-qt-translations
+CONFIG=                no-server no-bundled-speex no-bundled-opus no-update bundled-celt bundled-rnnoise \
+               no-alsa no-jackaudio no-portaudio no-pulseaudio no-dbus no-bonjour

P.S. Hope this can help to return ports audio/mumble and audio/murmur back!
Comment 2 gspu 2019-03-20 09:10:41 UTC
Please can you update the mumble and murmur Port?
2 Month and nothing :-(
Comment 3 Mark Felder freebsd_committer 2019-03-20 22:12:19 UTC
audio/murmur is back, I'm working on mumble.

I've been waiting *years* for them to release 1.3.0. The 1.2.x was not officially compatible with Qt5. It sort of worked in some areas, but was broken in others.
Comment 4 Mark Felder freebsd_committer 2019-03-21 00:00:44 UTC
Created attachment 203016 [details]
mumble 1.3.0-rc1
Comment 5 Mark Felder freebsd_committer 2019-03-21 00:01:06 UTC
Can someone build/run test this port? I don't have a FreeBSD desktop handy at the moment
Comment 6 VVD 2019-03-21 00:35:21 UTC
(In reply to Mark Felder from comment #5)
"make" work fine, "make install" will test later.
Comment 7 VVD 2019-03-21 01:56:06 UTC
Created attachment 203018 [details]
Mumble 1.3.0-r1

Your version build and run fine.
But I made patch for it - check, plz.
Comment 8 Mark Felder freebsd_committer 2019-03-21 03:47:46 UTC
What is the reason to exclude and disable Speex and Opus? I'm not up to speed on mumble development, but these are automatically fetched with their build instructions (git submodule init, etc)

Thanks!
Comment 9 VVD 2019-03-21 11:16:54 UTC
(In reply to Mark Felder from comment #8)
It isn't "disable Speex and Opus" at all - it's "disable bundled Speex and Opus".
Use system-wide (from ports) Speex and Opus.
Comment 10 Mark Felder freebsd_committer 2019-03-21 13:16:51 UTC
Thanks, I was overlooking that.
Comment 11 commit-hook freebsd_committer 2019-03-21 13:53:40 UTC
A commit references this bug:

Author: feld
Date: Thu Mar 21 13:53:05 UTC 2019
New revision: 496458
URL: https://svnweb.freebsd.org/changeset/ports/496458

Log:
  audio/mumble: Revive and update to 1.3.0-rc1

  - Now supports Qt5

  PR:		235177

Changes:
  head/audio/Makefile
  head/audio/mumble/
  head/audio/mumble/Makefile
  head/audio/mumble/distinfo
  head/audio/mumble/files/extrapatch-fix-build-boost-1.66
  head/audio/mumble/files/patch-compiler.pri
  head/audio/mumble/files/patch-cplusplus.pri
  head/audio/mumble/files/patch-overlay_gl-overlay.c
  head/audio/mumble/files/patch-overlay_overlay.h
  head/audio/mumble/files/patch-plugins-plugins.pri
  head/audio/mumble/files/patch-src-Net.cpp
  head/audio/mumble/files/patch-src-mumble-CELTCodec.cpp
  head/audio/mumble/files/patch-src-mumble-ServerHandler.cpp
  head/audio/mumble/files/patch-src-mumble-mumble.pro
  head/audio/mumble/files/patch-src-mumble-mumble_pch.hpp
  head/audio/mumble/pkg-plist
Comment 12 VVD 2019-03-21 19:09:59 UTC
1. no-pulseaudio 2 times.
2. no-xevie deprecated: was removed 2010-05-29 - check CHANGES file.
3. no-speechd - may be add option for it? accessibility/speech-dispatcher.
Comment 13 VVD 2019-03-21 19:37:40 UTC
Created attachment 203036 [details]
Added support for Speech Dispatcher

And removed not necesary CONFIG options.
Comment 14 commit-hook freebsd_committer 2019-03-21 22:19:04 UTC
A commit references this bug:

Author: feld
Date: Thu Mar 21 22:18:23 UTC 2019
New revision: 496517
URL: https://svnweb.freebsd.org/changeset/ports/496517

Log:
  audio/mumble: Remove unnecessary build flags

  - Also add speechd port option

  PR:		235177

Changes:
  head/audio/mumble/Makefile