Created attachment 201475 [details]
[PATCH] security/py-sslstrip: add missing dependency to RUN_DEPENDS
without 'security/py-service_identity' the following warning was produced:
:0: UserWarning: You do not have a working installation of the service_identity module: 'No module named service_identity'. Please install it from <https://pypi.python.org/pypi/service_identity> and make sure all of its dependencies are satisfied. Without the service_identity module, Twisted can perform only rudimentary TLS client hostname verification. Many valid certificate/hostname mappings may be rejected.
testport OK (11.2, 12.0, HEAD @ amd64, armv6, i386)
I'm taking this issue, and can take care of it as well.
Not a run depend since it runs without it but to get rid of warning sure why not.
(In reply to Matthew Donovan from comment #2)
Thank you Matthew! I should now just wait for an approval here, and the patch will land in the tree. Appreciated.
A commit references this bug:
Date: Thu Feb 7 13:23:51 UTC 2019
New revision: 492365
security/py-sslstrip: add missing dependency to RUN_DEPENDS
Submitted by: egypcio
Reviewed by: Matthew Donovan <kitchetech % gmail.com> (maintainer)
Approved by: rene (mentor)
(In reply to Rene Ladan from comment #4)