Bug 235336 - [maintainer-update] mail/qmail-tls to work with base openssl from 12
Summary: [maintainer-update] mail/qmail-tls to work with base openssl from 12
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-31 00:26 UTC by erdgeist
Modified: 2019-01-31 10:59 UTC (History)
1 user (show)

See Also:

Attachments
patch to make qmail-tls work on FreeBSD >= 12 (3.93 KB, patch)
2019-01-31 00:26 UTC, erdgeist 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description erdgeist 2019-01-31 00:26:24 UTC 
Created attachment 201544 [details]
patch to make qmail-tls work on FreeBSD >= 12

openssl >= 111 started to hide some internals so the original qmail-netqmail-1.06-tls-20160918.patch did not work anymore.

This new PORTREVISION adds a local patch to replace the offending accesses with their proper counterparts.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2019-01-31 06:36:48 UTC 
testbuilds@work
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2019-01-31 07:00:31 UTC 
fails to build in poudriere on 13 and 12, see for example:

http://people.freebsd.org/~pi/logs/mail__qmail-tls-120-1548916596.txt
Comment 3 erdgeist 2019-01-31 10:01:41 UTC 
(In reply to Kurt Jaeger from comment #2)

That's strange, the EXTRA_PATCHES that are guarded by

.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1200000
EXTRA_PATCHES+=	${FILESDIR}/netqmail-1.06-tls-20160918-freebsd-12.patch
.endif

in qmail/Makefile never are applied, so it's no wonder that it doesn't compile. Maybe the FreeBSD version is not what I need to check against but the openssl version that is configured?
Comment 4 erdgeist 2019-01-31 10:09:06 UTC 
(In reply to erdgeist from comment #3)

Could it be that the patches were only applied to the qmail-tls slave port folder and not the qmail folder?
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2019-01-31 10:53:15 UTC 
Looks like I made an error during the copy of the patches to the
poudriere tree. New run @work
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2019-01-31 10:59:26 UTC 
Committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2019-01-31 10:59:35 UTC 
A commit references this bug:

Author: pi
Date: Thu Jan 31 10:59:23 UTC 2019
New revision: 491703
URL: https://svnweb.freebsd.org/changeset/ports/491703

Log:
  mail/qmail-tls: patches to make it work with openssl 1.1.1 in base for 12+

  PR:		235336
  Submitted by:	erdgeist@erdgeist.org (maintainer)

Changes:
  head/mail/qmail/Makefile
  head/mail/qmail/files/netqmail-1.06-tls-20160918-freebsd-12.patch
  head/mail/qmail-tls/Makefile