Created attachment 201635 [details]
Patch to apply.
This updates www/py-wsgidav to 2.4.1.
This patch also removes a large number of development-only dependencies. While it's strictly an optional dependency, it also pulls in py-cheroot, as this is the default WSGI container WsgiDAV uses.
Thanks for the patch this looks good. Before moving forward can you please provide where where WegiDAV uses py-cheroot in there default WsgiDAV container?
Based on setup.py, it looks like it is only required on Windows based systems so I don't think it is a required dependency at all and would perfer to leave out if this is the case.
py-cheroot is an optional dependency. It's the default WSGI server WsgiDAV will attempt to use when you start it: https://github.com/mar10/wsgidav/blob/v2.4.1/wsgidav/server/server_cli.py#L136
I included it so that any users would have a complete experience out of the box. Formerly cherrypy was used for this, but cheroot was separated out from it. Removing it means potentially breaking installs for anybody who expects WsgiDAV to continue running without needing to install an additional WSGI server.
Hey, any updates?
Another possibility would be to add an option to decide whether Cheroot should be installed. I'd leave it on by default, just so as not to break any existing installs.
(In reply to Keith Gaughan from comment #3)
Have had lack of time to take a look. I'll try and get to it soon.
While wsgidav does have cheroot as the default option for startup, this is not considered a dependency and this is made clear in the projects help.
That being said I think the best route would be to add an options along with the additional 6 (some omitted if port doesn't currently exist) with cheroot being the only one installed by default.
A commit references this bug:
Date: Sat Mar 9 08:40:04 UTC 2019
New revision: 495108
* Updated to 2.4.1
* Fixed dependencies to match setup.py
* Added options for supported --server(s)
* Added test target with depends to test 3.7, which succeeded.
* Sorted Makefile for portlint
Only cheroot is default on for the new options which
is the default in wsgidav.
Reported by: Keith Gaughan <k@ster^.me>