Bug 235445 - [PATCH] editors/nvi-devel: Avoid "Text file busy" error when editing a script
Summary: [PATCH] editors/nvi-devel: Avoid "Text file busy" error when editing a script
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-03 00:52 UTC by Craig Leres
Modified: 2019-02-03 00:53 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (johans)


Attachments
patch (1.31 KB, patch)
2019-02-03 00:53 UTC, Craig Leres
leres: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer 2019-02-03 00:52:38 UTC
I found that unlike the base vi (nvi 2.1.3), nvi-devel calls flock() on a writable file descriptor. This has the unfortunately side effect of causing the "Text file busy" error when you edit a script in one window and try to run it in another.

The fix is to change the initial open() just prior to calling file_lock() in file_init() to use O_RDONLY instead of O_RDWR. This does not impact nvi's ability to write files, nvi creates a new file when writing.
Comment 1 Craig Leres freebsd_committer 2019-02-03 00:53:15 UTC
Created attachment 201664 [details]
patch