Bug 235469 - multimedia/mpv: enable VULKAN by default
Summary: multimedia/mpv: enable VULKAN by default
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: patch
Depends on: 227994
Blocks:
  Show dependency treegraph
 
Reported: 2019-02-03 20:07 UTC by Jan Beich
Modified: 2019-02-04 11:36 UTC (History)
2 users (show)

See Also:
cpm: maintainer-feedback+


Attachments
v1 (1.11 KB, patch)
2019-02-03 20:07 UTC, Jan Beich
cpm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2019-02-03 20:07:22 UTC
Created attachment 201693 [details]
v1

Vulkan (like Wayland) is the future. At the moment Vulkan is best supported on AMD GPUs on drm-kmod. Let package-only users try it.

Here're build logs:
- 11.2 aarch64: https://ptpb.pw/1XlR
- 11.2 amd64: https://ptpb.pw/5rAQ
- 11.2 armv6: https://ptpb.pw/4Fat
- 11.2 i386: https://ptpb.pw/Co7U
- 12.0 aarch64: https://ptpb.pw/1-Qp
- 12.0 amd64: https://ptpb.pw/tGMR
- 12.0 armv6: https://ptpb.pw/a_H-
- 12.0 armv7: https://ptpb.pw/ncsc
- 12.0 i386: https://ptpb.pw/EcrO
- 13.0 amd64: https://ptpb.pw/iYCt
- 13.0 armv7: https://ptpb.pw/AW8w
- 13.0 i386: https://ptpb.pw/JcnL
Comment 1 Jan Beich freebsd_committer 2019-02-03 21:48:27 UTC
FWIW, Vulkan should work fine on Intel with drm-kmod after mesa-dri upgrade to 19.0.0.
Comment 2 Carlos J. Puga Medina freebsd_committer 2019-02-03 23:35:41 UTC
(In reply to Jan Beich from comment #1)

Approved! Go ahead, Jan :)
Comment 3 commit-hook freebsd_committer 2019-02-03 23:38:30 UTC
A commit references this bug:

Author: jbeich
Date: Sun Feb  3 23:38:10 UTC 2019
New revision: 492084
URL: https://svnweb.freebsd.org/changeset/ports/492084

Log:
  multimedia/mpv: enable VULKAN by default

  PR:		235469
  Approved by:	cpm (maintainer)

Changes:
  head/multimedia/mpv/Makefile
Comment 4 VVD 2019-02-04 01:50:54 UTC
Option VULKAN isn't compatible with option WAYLAND:
/usr/bin/ld: error: undefined symbol: vkCreateWaylandSurfaceKHR
>>> referenced by context_wayland.c
>>>               video/out/vulkan/context_wayland.c.25.o:(wayland_vk_init)
cc: error: linker command failed with exit code 1 (use -v to see invocation)

Build fine with VULKAN or with WAYLAND option, but not with both.
Tested on 12.0 amd64.
Comment 5 Jan Beich freebsd_committer 2019-02-04 02:25:10 UTC
vkCreateWaylandSurfaceKHR is provided by graphics/vulkan-loader if built with WAYLAND=on. As the ports framework doesn't support requiring specific options in dependencies changing defaults outside of OPTIONS_SET/OPTIONS_UNSET in non-leaf ports is fragile. I've kind of anticipated an error like yours when writing 20181111 entry in UPDATING.
Comment 6 VVD 2019-02-04 11:36:18 UTC
(In reply to Jan Beich from comment #5)
Thanks, rebuild graphics/vulkan-loader with WAYLAND=on fixed mpv build.
IMHO, better to add some message about this dependency in multimedia/mpv - in pkg-descr or in Makefile.