Bug 235520 - [PATCH] audio/musicpd: Enable external playlist support
Summary: [PATCH] audio/musicpd: Enable external playlist support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-02-05 10:34 UTC by Peter Laursen
Modified: 2019-02-10 17:57 UTC (History)
0 users

See Also:
riggs: maintainer-feedback+
riggs: merge-quarterly+


Attachments
Patch to enable external playlist support, fix some portlint -C warnings (2.12 KB, patch)
2019-02-05 10:34 UTC, Peter Laursen
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Laursen 2019-02-05 10:34:23 UTC
Created attachment 201751 [details]
Patch to enable external playlist support, fix some portlint -C warnings

Hi,
I have just started using the port audio/musicpd.
I tried to download a podcast so that I could add it all to my library and discovered that the RSS playlist plugin was not enabled.
The attached patch:
* Enables external playlist support (most notably support for RSS feeds but also XSPF among others)
* Fix a couple small warnings identified by "portlint -C"

There are still a couple warnings remaining which I can't seem to be able to fix regarding the options "SOUNDCLOUD" and "TIDAL".

I have test-built this port on FreeBSD 12.0 on both amd64 and i386 using Poudriere.

If I can do anything further to help, please let me know.

All the best,

Peter.
Comment 1 commit-hook freebsd_committer 2019-02-10 15:44:54 UTC
A commit references this bug:

Author: riggs
Date: Sun Feb 10 15:44:22 UTC 2019
New revision: 492616
URL: https://svnweb.freebsd.org/changeset/ports/492616

Log:
  Enable support for external playlists (wma, RSS feed)

  Details:
  - Introduce default OPTION PLAYLISTS
  - New option PLAYLISTS depends on expat, which is in the default
    package pulled in as a dependency via ffmpeg anyway

  PR:		235520
  Submitted by:	freebsd@mosedal.net
  MFH:		2019Q1

Changes:
  head/audio/musicpd/Makefile
Comment 2 commit-hook freebsd_committer 2019-02-10 17:06:04 UTC
A commit references this bug:

Author: riggs
Date: Sun Feb 10 17:05:39 UTC 2019
New revision: 492619
URL: https://svnweb.freebsd.org/changeset/ports/492619

Log:
  MFH: r492616

  Enable support for external playlists (wma, RSS feed)

  Details:
  - Introduce default OPTION PLAYLISTS
  - New option PLAYLISTS depends on expat, which is in the default
    package pulled in as a dependency via ffmpeg anyway

  PR:		235520
  Submitted by:	freebsd@mosedal.net

  Approved by:	ports-secteam (riggs)

Changes:
_U  branches/2019Q1/
  branches/2019Q1/audio/musicpd/Makefile