Bug 235563 - New port: emulators/teo: Thomson TO8 Emulator
Summary: New port: emulators/teo: Thomson TO8 Emulator
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-07 00:32 UTC by Thomas Bernard
Modified: 2019-02-08 07:45 UTC (History)
0 users

See Also:


Attachments
emulators/teoemulator (2.82 KB, text/plain)
2019-02-07 00:32 UTC, Thomas Bernard
no flags Details
emulator_teoemulator.shar (5.16 KB, text/plain)
2019-02-07 00:36 UTC, Thomas Bernard
no flags Details
emulators_teo.shar (5.77 KB, text/plain)
2019-02-07 23:48 UTC, Thomas Bernard
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Bernard 2019-02-07 00:32:47 UTC
Created attachment 201804 [details]
emulators/teoemulator

The Thomson TO8 is a french 8 bits computer released in 1987
It was based on the Motorola 6809 CPU
Comment 1 Thomas Bernard 2019-02-07 00:36:37 UTC
Created attachment 201805 [details]
emulator_teoemulator.shar

fixed emulator_teoemulator.shar
(the previous one was missing patches)
Comment 2 Tobias Kortkamp freebsd_committer 2019-02-07 08:40:11 UTC
Any reason to name the package teoemulator instead of just teo?  AFAICT the
teo package name is still free.

XUSES=		gmake pkgconfig

This is missing USES=gnome.  Please define DEVELOPER=yes in your
/etc/make.conf when testing ports to enable more QA warnings.

XINSTALLS_ICONS=	no

The framework checks if INSTALLS_ICONS is defined or not.  The value doesn't
matter much.  So if the intent is to not have a gtk-update-icon-cache
dependency, then this should be dropped, otherwise it should be "yes" for
consistency with other ports.  It looks like you can safely remove this.

XPLIST_DIRS=	${DATADIR_REL}/rom	\
X	${DATADIR_REL}/icons
XROM_FILES=	basic1 basic512 expl extramon monitor1 monitor2
XICON_FILES=	leave run step stepover
XPLIST_FILES=	bin/teo	\
X	${ROM_FILES:%=${DATADIR_REL}/rom/%.rom} \
X	${ICON_FILES:%=${DATADIR_REL}/icons/%.ico}

This is too complicated. It would be nicer if you could generate a
pkg-plist with `make makeplist` instead.

X	@echo "MAKEFILE_INC = makefile.lnx" > ${WRKSRC}/Makefile
X	@echo "include makefile.all" >> ${WRKSRC}/Makefile

Use ${ECHO_CMD} instead of echo.

XDEBUG_CFLAGS_OFF=	-DNDEBUG

This currently does nothing (there is no DEBUG option defined in the port).
Comment 3 Thomas Bernard 2019-02-07 23:14:28 UTC
Indeed "teo" would be OK. It is just that the project name on sourceforge is "teoemulator"
https://sourceforge.net/projects/teoemulator/
Comment 4 Thomas Bernard 2019-02-07 23:48:27 UTC
Created attachment 201828 [details]
emulators_teo.shar

new version of the port
Comment 5 commit-hook freebsd_committer 2019-02-08 07:45:11 UTC
A commit references this bug:

Author: tobik
Date: Fri Feb  8 07:44:47 UTC 2019
New revision: 492411
URL: https://svnweb.freebsd.org/changeset/ports/492411

Log:
  New port: emulators/teo

  Teo is an emulator of the Thomson TO8 microcomputer for PC, running
  on MSDOS, Windows, Linux, and FreeBSD.

  The compatibility is close to 100% for softwares which don't use
  non emulated peripherals and don't hold physical protections.

  WWW: https://sourceforge.net/projects/teoemulator/

  PR:		235563
  Submitted by:	Thomas Bernard <nanard@free.fr>

Changes:
  head/emulators/Makefile
  head/emulators/teo/
  head/emulators/teo/Makefile
  head/emulators/teo/distinfo
  head/emulators/teo/files/
  head/emulators/teo/files/patch-makefile.all
  head/emulators/teo/files/patch-makefile.lnx
  head/emulators/teo/files/patch-src_linux_ufloppy.c
  head/emulators/teo/files/patch-src_std.c
  head/emulators/teo/pkg-descr
  head/emulators/teo/pkg-plist
Comment 6 Tobias Kortkamp freebsd_committer 2019-02-08 07:45:24 UTC
Committed with some minor changes. Thanks!