Bug 235566 - multimedia/vlc: fails to build on 12.0-RELEASE
Summary: multimedia/vlc: fails to build on 12.0-RELEASE
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-07 03:39 UTC by Alexander Shikov
Modified: 2019-03-19 09:24 UTC (History)
1 user (show)

See Also:
riggs: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Shikov 2019-02-07 03:39:04 UTC
Hello!
multimedia/vlc fails to build on FreeBSD 12.0-RELEASE-p1:

# cd /usr/ports/multimedia/vlc
# make clean && make

[...]

../doltcompile cc -DHAVE_CONFIG_H -I. -I..   -I../include -I../include -I/usr/local/include -DLIBICONV_PLUG  -O2 -pipe  -DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing   -Werror=unknown-warning-option -Werror=invalid-command-line-argument -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self -fvisibility=hidden -O3 -fno-math-errno -funsafe-math-optimizations -funroll-loops -fomit-frame-pointer -fstack-protector-strong -MT tdestroy.lo -MD -MP -MF $depbase.Tpo -c -o tdestroy.lo tdestroy.c &&\
mv -f $depbase.Tpo $depbase.Plo
depbase=`echo strverscmp.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
../doltcompile cc -DHAVE_CONFIG_H -I. -I..   -I../include -I../include -I/usr/local/include -DLIBICONV_PLUG  -O2 -pipe  -DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing   -Werror=unknown-warning-option -Werror=invalid-command-line-argument -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self -fvisibility=hidden -O3 -fno-math-errno -funsafe-math-optimizations -funroll-loops -fomit-frame-pointer -fstack-protector-strong -MT strverscmp.lo -MD -MP -MF $depbase.Tpo -c -o strverscmp.lo strverscmp.c &&\
mv -f $depbase.Tpo $depbase.Plo
cc1: error: -Werror=unknown-warning-option: No option -Wunknown-warning-option
cc1: error: -Werror=invalid-command-line-argument: No option -Winvalid-command-line-argument
cc1: error: unrecognized command line option "-fstack-protector-strong"
cc1: error: -Werror=unknown-warning-option: No option -Wunknown-warning-option
cc1: error: -Werror=invalid-command-line-argument: No option -Winvalid-command-line-argument
cc1: error: unrecognized command line option "-fstack-protector-strong"
cc1: error: -Werror=unknown-warning-option: No option -Wunknown-warning-option
cc1: error: -Werror=invalid-command-line-argument: No option -Winvalid-command-line-argument
cc1: error: unrecognized command line option "-fstack-protector-strong"
gmake[5]: *** [Makefile:1426: strverscmp.lo] Error 1
gmake[5]: *** Waiting for unfinished jobs....
gmake[5]: *** [Makefile:1426: dummy.lo] Error 1
gmake[5]: *** [Makefile:1426: tdestroy.lo] Error 1
gmake[5]: Leaving directory '/usr/ports/multimedia/vlc/work/vlc-3.0.6/compat'
gmake[4]: *** [Makefile:1252: all] Error 2
gmake[4]: Leaving directory '/usr/ports/multimedia/vlc/work/vlc-3.0.6/compat'
gmake[3]: *** [Makefile:1539: all-recursive] Error 1
gmake[3]: Leaving directory '/usr/ports/multimedia/vlc/work/vlc-3.0.6'
gmake[2]: *** [Makefile:1424: all] Error 2
gmake[2]: Leaving directory '/usr/ports/multimedia/vlc/work/vlc-3.0.6'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/multimedia/vlc
*** Error code 1

Stop.
make: stopped in /usr/ports/multimedia/vlc


Build options are:
# This file is auto-generated by 'make config'.
# Options for vlc-3.0.6_1,4
_OPTIONS_READ=vlc-3.0.6_1,4
_FILE_COMPLETE_OPTIONS_LIST=A52 AALIB AOM ASS AVAHI CACA CHROMECAST DAV1D DBUS DCA DOCS DVDNAV DVDREAD FAAD FLAC FLUID FREERDP FRIBIDI GME GNUTLS GOOM HARFBUZZ JACK KATE LIBBLURAY LIBPLACEBO LIBRSVG2 LIBSSH2 LIRC LIVEMEDIA LUA MAD MODPLUG MPEG2 MTP MUSEPACK NCURSES NFS NLS NOTIFY OGG OPTIMIZED_CFLAGS OPUS PNG PULSEAUDIO QT5 REALRTSP RUNROOT SAMPLERATE SCHROEDINGER SDL SHOUTCAST SIDPLAY SKINS SMB SNDIO SPEEX STREAM TAGLIB THEORA TWOLAME UPNP V4L VAAPI VCD VDPAU VORBIS VPX WAYLAND X11 X264 X265 ZVBI
OPTIONS_FILE_SET+=A52
OPTIONS_FILE_UNSET+=AALIB
OPTIONS_FILE_UNSET+=AOM
OPTIONS_FILE_UNSET+=ASS
OPTIONS_FILE_UNSET+=AVAHI
OPTIONS_FILE_UNSET+=CACA
OPTIONS_FILE_UNSET+=CHROMECAST
OPTIONS_FILE_UNSET+=DAV1D
OPTIONS_FILE_SET+=DBUS
OPTIONS_FILE_UNSET+=DCA
OPTIONS_FILE_SET+=DOCS
OPTIONS_FILE_UNSET+=DVDNAV
OPTIONS_FILE_UNSET+=DVDREAD
OPTIONS_FILE_SET+=FAAD
OPTIONS_FILE_UNSET+=FLAC
OPTIONS_FILE_UNSET+=FLUID
OPTIONS_FILE_UNSET+=FREERDP
OPTIONS_FILE_UNSET+=FRIBIDI
OPTIONS_FILE_UNSET+=GME
OPTIONS_FILE_UNSET+=GNUTLS
OPTIONS_FILE_UNSET+=GOOM
OPTIONS_FILE_UNSET+=HARFBUZZ
OPTIONS_FILE_UNSET+=JACK
OPTIONS_FILE_UNSET+=KATE
OPTIONS_FILE_UNSET+=LIBBLURAY
OPTIONS_FILE_UNSET+=LIBPLACEBO
OPTIONS_FILE_UNSET+=LIBRSVG2
OPTIONS_FILE_UNSET+=LIBSSH2
OPTIONS_FILE_UNSET+=LIRC
OPTIONS_FILE_UNSET+=LIVEMEDIA
OPTIONS_FILE_UNSET+=LUA
OPTIONS_FILE_SET+=MAD
OPTIONS_FILE_UNSET+=MODPLUG
OPTIONS_FILE_SET+=MPEG2
OPTIONS_FILE_UNSET+=MTP
OPTIONS_FILE_UNSET+=MUSEPACK
OPTIONS_FILE_UNSET+=NCURSES
OPTIONS_FILE_UNSET+=NFS
OPTIONS_FILE_SET+=NLS
OPTIONS_FILE_UNSET+=NOTIFY
OPTIONS_FILE_SET+=OGG
OPTIONS_FILE_SET+=OPTIMIZED_CFLAGS
OPTIONS_FILE_UNSET+=OPUS
OPTIONS_FILE_UNSET+=PNG
OPTIONS_FILE_UNSET+=PULSEAUDIO
OPTIONS_FILE_UNSET+=QT5
OPTIONS_FILE_UNSET+=REALRTSP
OPTIONS_FILE_UNSET+=RUNROOT
OPTIONS_FILE_UNSET+=SAMPLERATE
OPTIONS_FILE_UNSET+=SCHROEDINGER
OPTIONS_FILE_UNSET+=SDL
OPTIONS_FILE_UNSET+=SHOUTCAST
OPTIONS_FILE_UNSET+=SIDPLAY
OPTIONS_FILE_UNSET+=SKINS
OPTIONS_FILE_UNSET+=SMB
OPTIONS_FILE_UNSET+=SNDIO
OPTIONS_FILE_UNSET+=SPEEX
OPTIONS_FILE_UNSET+=STREAM
OPTIONS_FILE_SET+=TAGLIB
OPTIONS_FILE_SET+=THEORA
OPTIONS_FILE_SET+=TWOLAME
OPTIONS_FILE_UNSET+=UPNP
OPTIONS_FILE_UNSET+=V4L
OPTIONS_FILE_SET+=VAAPI
OPTIONS_FILE_UNSET+=VCD
OPTIONS_FILE_SET+=VDPAU
OPTIONS_FILE_SET+=VORBIS
OPTIONS_FILE_UNSET+=VPX
OPTIONS_FILE_SET+=WAYLAND
OPTIONS_FILE_SET+=X11
OPTIONS_FILE_SET+=X264
OPTIONS_FILE_SET+=X265
OPTIONS_FILE_UNSET+=ZVBI
Comment 1 Jan Beich freebsd_committer 2019-02-07 12:05:58 UTC
Looks like the compiler used is too old. Can you show output  from the following?

$ `make -V CC -C/usr/ports/multimedia/vlc` --version
$ make -V CHOSEN_COMPILER_TYPE -C/usr/ports/multimedia/vlc
Comment 2 Alexander Shikov 2019-02-07 13:07:26 UTC
# `make -V CC -C/usr/ports/multimedia/vlc` --version
FreeBSD clang version 6.0.1 (tags/RELEASE_601/final 335540) (based on LLVM 6.0.1)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /usr/bin


# make -V CHOSEN_COMPILER_TYPE -C/usr/ports/multimedia/vlc
clang
Comment 3 Thomas Zander freebsd_committer 2019-03-02 07:23:18 UTC
This indeed looks like you are compiling with the old gcc 4 from base. clang 6.0.1 definitely supports -fstack-protector-strong. I just built vlc on 12.0-RELEASE-p3 with no problems.

Also, during configure stage, vlc tests for this compiler flag:
...
checking whether C compiler accepts -fstack-protector-strong... yes
...
Is this test working on your machine? If so, configure and build stages might use different compilers. Any non-default settings in make.conf?
Comment 4 Alexander Shikov 2019-03-05 09:18:42 UTC
Nothing unusual in /etc/make.conf:

# cat /etc/make.conf | egrep -v '^#'
DOC_LANG=       en_US.ISO8859-1 ru_RU.KOI8-R
KERNCONF=CRETE
BATCH_DELETE_OLD_FILES=YES
DEFAULT_VERSIONS+=linux=c6

I've upgraded FreeBSD to latest 12.0-RELEASE-p3 from sources, removed /usr/ports and extracted latest ports tree from scratch. That did not solve the problem.

/usr/ports/multimedia/vlc>make configure | grep fstack-protector-strong
checking whether C compiler accepts -fstack-protector-strong... yes
checking whether C compiler accepts -fstack-protector-strong... (cached) yes

Here are also lines from config.log which are related to -fstack-protector-strong flag:

configure:28545: checking whether C compiler accepts -fstack-protector-strong
configure:28564: cc -c -O2 -pipe  -DLIBICONV_PLUG -fstack-protector -fno-strict-aliasing   -Werror=unknown-warning-option -Werror=invalid-command-line-argument -Wall -Wextra -Wsign-compare -Wundef -Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security -Wbad-function-cast -Wwrite-strings -Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self -fvisibility=hidden -O3 -fno-math-errno -funsafe-math-optimizations -funroll-loops -fomit-frame-pointer  -fstack-protector-strong -I/usr/local/include -DLIBICONV_PLUG conftest.c >&5
configure:28564: $? = 0
configure:28573: result: yes


If you need I can provide a remote access to my box.
Thanks.
Comment 5 Thomas Zander freebsd_committer 2019-03-16 07:20:16 UTC
Do you happen to have a full poudriere log?
Comment 6 Alexander Shikov 2019-03-19 09:24:22 UTC
Hi!

Kind apologises, it was my fault with rudiment in my installation, just old bash binary:

problematic:
checking for bash... /bin/bash
checking if dolt supports this host... yes, replacing libtool

vs.

normal:
checking for bash... /usr/local/bin/bash
checking if dolt supports this host... yes, replacing libtool

Thank you for clues and support!