Bug 235584 - www/serf: rename options to be more consistent with other ports
Summary: www/serf: rename options to be more consistent with other ports
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Lev A. Serebryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-07 20:11 UTC by Phillip R. Jaenke
Modified: 2019-02-11 12:51 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (lev)


Attachments
www_serf_Makefile.patch (1.32 KB, text/plain)
2019-02-07 20:11 UTC, Phillip R. Jaenke
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Phillip R. Jaenke 2019-02-07 20:11:39 UTC
Created attachment 201823 [details]
www_serf_Makefile.patch

www/serf uses the option names "HEIMDAL_BASE", "HEIMDAL", and "MIT" whereas the majority of other ports use "GSSAPI_${TYPE}". GSSAPI type should generally be set system wide so consistency of option naming matters.

Attached patch does nothing more than rename the options to be more consistent with other ports.
HEIMDAL_BASE -> GSSAPI_BASE
HEIMDAL -> GSSAPI_HEIMDAL
MIT -> GSSAPI_MIT
Comment 1 commit-hook freebsd_committer 2019-02-11 12:50:43 UTC
A commit references this bug:

Author: lev
Date: Mon Feb 11 12:49:52 UTC 2019
New revision: 492691
URL: https://svnweb.freebsd.org/changeset/ports/492691

Log:
    Rename Kerberos-related options to system-wide names.

  PR:		235584
  Submitted by:	prj@rootwyrm.com

Changes:
  head/www/serf/Makefile
Comment 2 Lev A. Serebryakov freebsd_committer 2019-02-11 12:51:33 UTC
Committed, thnx!