Bug 235596 - Mk/Uses/gmake: new optional arguments -- `extract` and `patch`
Summary: Mk/Uses/gmake: new optional arguments -- `extract` and `patch`
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Package Infrastructure (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-08 12:24 UTC by Iblis Lin
Modified: 2019-02-14 11:10 UTC (History)
1 user (show)

See Also:

Attachments
gmake.mk patch (1011 bytes, patch)
2019-02-08 12:24 UTC, Iblis Lin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Iblis Lin 2019-02-08 12:24:05 UTC 
Created attachment 201836 [details]
gmake.mk patch

I tried to use EXTRACT_DEPENDS = gmake:..., but it make portlint unhappy.
Comment 1 Iblis Lin 2019-02-08 12:25:58 UTC 
Where can I add some test cases to?
Comment 2 Mathieu Arnold freebsd_committer freebsd_triage 2019-02-08 13:29:52 UTC 
Why would you need gmake during patch?
Comment 3 Iblis Lin 2019-02-08 13:36:13 UTC 
(In reply to Mathieu Arnold from comment #2)
well, it's a quite complex case.
I'm working on porting Julia v1.1.
In order to get `shebangfix`, I need to extract/patch tarball before `shebangfix` routine get executed. 
There are some tarballs inside the WRKSRC in this case:
https://github.com/lwhsu/freebsd-ports-lang-julia/blob/master/julia11/Makefile#L126
Comment 4 Mathieu Arnold freebsd_committer freebsd_triage 2019-02-08 13:59:26 UTC 
Mmmm, ok, then just put gmake in EXTRACT_DEPENDS like you did, and ignore portlint, it's being silly.
Comment 5 Mathieu Arnold freebsd_committer freebsd_triage 2019-02-14 11:10:55 UTC 
Patch is not needed.