Bug 235700 - oce(4) driver causes fatal trap 12 on boot with emulex 10gbe nic
Summary: oce(4) driver causes fatal trap 12 on boot with emulex 10gbe nic
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: 11.2-STABLE
Hardware: amd64 Any
: --- Affects Many People
Assignee: freebsd-net mailing list
URL:
Keywords: crash, needs-qa, patch, regression
Depends on:
Blocks:
 
Reported: 2019-02-12 16:19 UTC by Sajeev Ramasamy
Modified: 2019-02-24 19:45 UTC (History)
4 users (show)

See Also:
koobs: mfc-stable12?
koobs: mfc-stable11?


Attachments
Fatal 12 error log (186.67 KB, image/jpeg)
2019-02-12 16:19 UTC, Sajeev Ramasamy
no flags Details
Fix panic in OCE (617 bytes, patch)
2019-02-15 18:43 UTC, Ryan Moeller
no flags Details | Diff
Bounds check array accesses in oce driver (808 bytes, patch)
2019-02-23 19:45 UTC, Ryan Moeller
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sajeev Ramasamy 2019-02-12 16:19:38 UTC
Created attachment 201962 [details]
Fatal 12 error log

The new oce(4) drivers include from version 11.2 and above causes boot panic with emulex 10gbe nic. The driver included in 11.1-STABLE release works without any issues. So please kindly rollback the driver to the version included in 11.1-STABLE release.
Comment 1 Ryan Moeller 2019-02-15 18:43:29 UTC
Created attachment 202047 [details]
Fix panic in OCE

I also experienced this issue, and came up with a patch that solved the panic. That machine is currently in pieces waiting for a replacement motherboard, but I think this was the change I applied.
Comment 2 Sajeev Ramasamy 2019-02-23 11:58:20 UTC
(In reply to Ryan Moeller from comment #1)
Hey, sorry for the late reply. Thanks for your patch, but that line is no longer present in the new file.
Comment 3 Ryan Moeller 2019-02-23 19:45:04 UTC
Created attachment 202296 [details]
Bounds check array accesses in oce driver

My machine is operational again. Here is the actual patch that applies to HEAD. The same idea applies to 12 and 11 as well, though maybe on different line numbers.
Comment 4 Sajeev Ramasamy 2019-02-24 15:58:11 UTC
(In reply to Ryan Moeller from comment #3)
Hey, sorry to bother you again, but i'm not able to find those lines in 11.2-RELEASE version. https://github.com/freebsd/freebsd/blob/release/11.2.0/sys/dev/oce/oce_if.c
Comment 5 Ryan Moeller 2019-02-24 16:54:48 UTC
(In reply to Sajeev Ramasamy from comment #4)
Ah I see the confusion. Those lines are in stable/11, but not in 11.2-release.
https://github.com/freebsd/freebsd/blob/stable/11/sys/dev/oce/oce_if.c#L2392-L2395