Bug 235737 - sysutils/google-compute-engine-oslogin: update to 1.4.3
Summary: sysutils/google-compute-engine-oslogin: update to 1.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Steve Wills
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-02-14 13:20 UTC by Lucas Kanashiro
Modified: 2019-03-01 03:15 UTC (History)
1 user (show)

See Also:
helen.koike: maintainer-feedback+
helen.koike: merge-quarterly?

Attachments
Patch to update to version 1.4.3 (13.95 KB, patch)
2019-02-14 13:20 UTC, Lucas Kanashiro 		no flags Details | Diff
poudriere logs using freebsd 11.2 (24.21 KB, text/plain)
2019-02-14 13:21 UTC, Lucas Kanashiro 		no flags Details
poudriere logs using freebsd 12 (23.69 KB, text/plain)
2019-02-14 13:21 UTC, Lucas Kanashiro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Kanashiro 2019-02-14 13:20:07 UTC 
Created attachment 202015 [details]
Patch to update to version 1.4.3

Update to the latest upstream version (1.4.3) to enable new features in GCE cloud images.

The file files/patch-bin_google__oslogin__control was removed since this modification was applied by upstream in this latest version.
Comment 1 Lucas Kanashiro 2019-02-14 13:21:19 UTC 
Created attachment 202016 [details]
poudriere logs using freebsd 11.2
Comment 2 Lucas Kanashiro 2019-02-14 13:21:42 UTC 
Created attachment 202017 [details]
poudriere logs using freebsd 12
Comment 3 Helen Koike 2019-02-15 12:48:37 UTC 
It would be nice if pam_syslog could be wrapped in some ifndef in the upstream code.
Comment 4 commit-hook freebsd_committer freebsd_triage 2019-03-01 03:14:46 UTC 
A commit references this bug:

Author: swills
Date: Fri Mar  1 03:14:33 UTC 2019
New revision: 494231
URL: https://svnweb.freebsd.org/changeset/ports/494231

Log:
  sysutils/google-compute-engine-oslogin: update to 1.4.3

  PR:		235737
  Submitted by:	Lucas Kanashiro <lucas.kanashiro@collabora.com>
  Approved by:	Helen Koike <helen.koike@collabora.com> (maintainer)

Changes:
  head/sysutils/google-compute-engine-oslogin/Makefile
  head/sysutils/google-compute-engine-oslogin/distinfo
  head/sysutils/google-compute-engine-oslogin/files/patch-bin_google__oslogin__control
  head/sysutils/google-compute-engine-oslogin/files/patch-pam__module_pam__oslogin__admin.cc
  head/sysutils/google-compute-engine-oslogin/files/patch-pam__module_pam__oslogin__login.cc
  head/sysutils/google-compute-engine-oslogin/files/patch-utils_oslogin__utils.cc
Comment 5 Steve Wills freebsd_committer freebsd_triage 2019-03-01 03:15:46 UTC 
Committed. Some of the patch changes were not correct (changed %%PREFIX%% to /usr/local) or unnecessary (date/time change only) so I didn't commit those. Thanks for the patch!