Bug 235744 - databases/mariadb103-client: mariadb_config broken after Rev: 490140
Summary: databases/mariadb103-client: mariadb_config broken after Rev: 490140
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks: 235631 236698
  Show dependency treegraph
 
Reported: 2019-02-14 14:15 UTC by Dani I.
Modified: 2019-03-23 22:27 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (brnrd)


Attachments
~/FreeBSD/patchs/mariadb103-1.patch (1.79 KB, patch)
2019-02-23 15:56 UTC, Danilo G. Baio
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani I. 2019-02-14 14:15:07 UTC
With revision ports r490140 mariadb_config is broken again and some ports fail to build. For example apr1 port:
===========================================================================
=======================<phase: package        >============================
===>  Building package for apr-1.6.5.1.6.1_1
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/apr1/work/stage/usr/local/lib/apr-util-1/apr_dbd_mysql-1.so:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/apr1/work/stage/usr/local/lib/apr-util-1/apr_dbd_mysql.a:No such file or directory
pkg-static: Unable to access file /wrkdirs/usr/ports/devel/apr1/work/stage/usr/local/lib/apr-util-1/apr_dbd_mysql.so:No such file or directory
*** Error code 1

Stop.
make: stopped in /usr/ports/devel/apr1
===========================================================================
There was a patch which fixed this issue in revision: ports r483598
Related PR's: bug #226049 bug #230538

After readding the patch, everything works fine again:
===========================================================================
=======================<phase: package        >============================
===>  Building package for apr-1.6.5.1.6.1_1
===========================================================================
=>> Cleaning up wrkdir
===>  Cleaning for apr-1.6.5.1.6.1_1
build of devel/apr1 | apr-1.6.5.1.6.1_1 ended at Thu Feb 14 11:36:30 CET 2019
build time: 00:00:47
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2019-02-23 15:56:00 UTC
Created attachment 202290 [details]
~/FreeBSD/patchs/mariadb103-1.patch

This patch returns prior behavior of mysql_config.

File `scripts/mysql_config.sh` can be repo copied.

We noticed a build problem with zabbix and mariadb103, these are the details:

mysql=10.1m
	checking for mysql_config... /usr/local/bin/mysql_config
	checking for main in -lmysqlclient... yes

	Shared library: [libmysqlclient.so.18]

	$ mysql_config --libs
      -L/usr/local/lib/mysql  -lmysqlclient -pthread -lz -lm -lexecinfo -L/usr/local/lib

mysql=10.2m
	checking for mysql_config... /usr/local/bin/mysql_config
	checking for main in -lmariadb... yes

	Shared library: [libmariadb.so.3]

    $ mysql_config --libs
      -L/usr/local/lib/mysql/ -lmariadb -lz -lm -liconv -lssl -lcrypto -liconv -L/usr/local/lib

mysql=10.3m
	checking for mysql_config... /usr/local/bin/mysql_config
	checking for main in -lmariadb... no
	configure: error: Not found mariadb library

    $ mysql_config --libs
      -L/usr/local/lib/mysql/ -lmariadb -lz -lm -liconv -lssl -lcrypto -liconv

with this patch:
	checking for mysql_config... /usr/local/bin/mysql_config
	checking for main in -lmariadb... yes

	Shared library: [libmariadb.so.3]

	$ mysql_config --libs
      -L/usr/local/lib/mysql/ -lmariadb -lz -lm -liconv -lssl -lcrypto -liconv -L/usr/local/lib
Comment 2 Miroslav Lachman 2019-02-23 21:42:10 UTC
I can confirm this patch fixed the problem with building Zabbix4.
Comment 3 Dani I. 2019-03-19 08:42:11 UTC
Bump...
Comment 4 Fred Condo 2019-03-19 16:37:41 UTC
Is there anything I can do to help resolve this issue?
Comment 5 White Lynx 2019-03-21 14:55:57 UTC
I confirm that the patch resolves issue of installing apr (bug #236698). Hope it will go to ports.
Comment 6 commit-hook freebsd_committer freebsd_triage 2019-03-23 22:26:33 UTC
A commit references this bug:

Author: brnrd
Date: Sat Mar 23 22:26:25 UTC 2019
New revision: 496689
URL: https://svnweb.freebsd.org/changeset/ports/496689

Log:
  databases/mariadb103-client: Fix mariadb_config

   * Partial revert of r490140

  PR:		235744
  Submitted by:	Dani <i dani outlook com>
  MFH:		2019Q1
  Differential Revision:	https://reviews.freebsd.org/D19691

Changes:
  head/databases/mariadb103-client/Makefile
Comment 7 Bernard Spil freebsd_committer freebsd_triage 2019-03-23 22:27:46 UTC
Hi all,

Sorry... Introduced this issue in 490140

Reverted, should be fine now. This doesn't show up in my QA tests, only when building software that depends on mariadb_config.

Cheers, Bernard.