Bug 235834 - net/mosquitto: OpenSSL build fix broke mosquitto_passwd
Summary: net/mosquitto: OpenSSL build fix broke mosquitto_passwd
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: regression
Depends on:
Blocks:
 
Reported: 2019-02-18 11:28 UTC by Ari Suutari
Modified: 2019-03-11 01:19 UTC (History)
2 users (show)

See Also:
joe: maintainer-feedback+
koobs: merge-quarterly?


Attachments
Fixed mosquitto_internal.h patch which defines HAVE_OPENSSL_OPAQUE_STRUCTS (1.05 KB, patch)
2019-02-18 11:28 UTC, Ari Suutari
no flags Details | Diff
Fixed mosquitto_passwd.c patch with correct #ifndef. (1.00 KB, text/plain)
2019-02-18 11:29 UTC, Ari Suutari
no flags Details
new patch for mosquitto_passwd.c (424 bytes, text/plain)
2019-02-18 13:25 UTC, Ari Suutari
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ari Suutari 2019-02-18 11:28:59 UTC
Created attachment 202125 [details]
Fixed mosquitto_internal.h patch which defines HAVE_OPENSSL_OPAQUE_STRUCTS

OpenSSL fixes from bug #232168 break mosquitto_passwd. The problem was originally 
mentioned here:

https://github.com/eclipse/mosquitto/issues/1032

The patches reference HAVE_OPENSSL_OPAQUE_STRUCTS, but that is not defined anywhere. Also, #ifdef in mosquitto_passwd.c patch should be #ifndef.
Comment 1 Ari Suutari 2019-02-18 11:29:38 UTC
Created attachment 202126 [details]
Fixed mosquitto_passwd.c patch with correct #ifndef.
Comment 2 Ari Suutari 2019-02-18 13:25:55 UTC
Created attachment 202127 [details]
new patch for mosquitto_passwd.c

Fix was actually simpler. No need to modify patch-lib_mosquitto__internal.h.
Comment 3 joe 2019-03-11 01:19:06 UTC
PS: The utility is broken on 11.2-RELEASE.

See the updated version here:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236459