Bug 235898 - Mk/Uses/qt.mk: Complain about components with an unknown suffix instead of silently accepting them
Summary: Mk/Uses/qt.mk: Complain about components with an unknown suffix instead of si...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://reviews.freebsd.org/D19267
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-02-20 19:38 UTC by Tobias Kortkamp
Modified: 2019-02-20 21:25 UTC (History)
0 users

See Also:
tobik: exp-run?

Attachments
D19267.diff (480 bytes, patch)
2019-02-20 19:38 UTC, Tobias Kortkamp 		tobik: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-02-20 19:38:31 UTC 
Created attachment 202202 [details]
D19267.diff

See https://reviews.freebsd.org/D19267.

Requesting an exp-run for this to be on the safe side.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2019-02-20 19:59:22 UTC 
Please run "make -VIGNORE" on all ports instead, no need for an exp-run.
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-02-20 21:24:38 UTC 
A commit references this bug:

Author: tobik
Date: Wed Feb 20 21:24:33 UTC 2019
New revision: 493464
URL: https://svnweb.freebsd.org/changeset/ports/493464

Log:
  Mk/Uses/qt.mk: Complain about components with an unknown suffix

  Normally, USE_QT complains about unknown components with

  	===>  $PKGNAME cannot be installed: unknown USE_QT component
  	'foobar'.

  However this fails if the component has a suffix starting with `_`.
  For example

  	USE_QT=	buildtools_build,core

  or even a simple

  	USE_QT=	buildtools_buld

  is silently accepted, but they do not do anything.  Only components
  with _build and _run suffixes should be accepted.

  Amend the regular expression we use for this to be stricter.  It
  is currently over eager.  Since we only have two cases to cover
  here we can spell them out explictly instead.

  PR:		235898
  Approved by:	kde (tcberner)
  Differential Revision:	https://reviews.freebsd.org/D19267

Changes:
  head/Mk/Uses/qt.mk