Bug 235919 - astro/gpsbabel does not build, unknown USE_QT component 'uic'
Summary: astro/gpsbabel does not build, unknown USE_QT component 'uic'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tilman Keskinoz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-21 16:05 UTC by Miroslav Lachman
Modified: 2019-03-19 20:46 UTC (History)
2 users (show)

See Also:
dev2: maintainer-feedback+


Attachments
poudriere build failure full log (99.22 KB, text/plain)
2019-02-21 19:34 UTC, Miroslav Lachman
no flags Details
proposed patch to Makefile (554 bytes, patch)
2019-03-10 11:22 UTC, Oliver Heesakkers
dev2: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Lachman 2019-02-21 16:05:02 UTC
I am trying to build updated packages form my desktop in Poudriere on 11.2 amd64 and gpsbabel gives me instant build failure:

cannot be installed: unknown USE_QT component 'uic'

No log created by Poudriere.

My options are:

DEFAULT_VERSIONS=apache=2.4 perl5=5.28 mysql=10.2m php=7.1 python=2.7 python3=3.6 pgsql=9.6 ssl=libressl
Comment 1 Oliver Heesakkers 2019-02-21 18:52:59 UTC
Hmmm, looks like when the switch was made from qt4 to qt5 (227538) this was overlooked.

You've ticked the GUI option which is something I believe very few people do, that explains why this wasn't brought to my attention earlier.

According to qt.mk mic, rss and uic are QT4 options, so that explains the error when building with QT5

I don't have a FreeBSD desktop readily available at the moment (and still prefer gpsbabel 1.4 to 1.5), so would you be willing to try and change line 34 in the Makefile from:

GUI_USE+=       QT=linguisttools_build,moc_build,rcc_build,uic_build

to 

GUI_USE+=       QT=linguisttools_build

and see if that
a: fixes the build (pretty sure it will)
b: gives you a running and usable gpsbabel (that's the one I'm wondering about)
Comment 2 Miroslav Lachman 2019-02-21 19:32:24 UTC
Thank you for your quick reply and help. Really appreciated.

I tried your suggested fix but it failed again:

cd gui ; qmake app.pro && make
Info: creating stash file /wrkdirs/usr/ports/astro/gpsbabel/work/gpsbabel-gpsbabel_1_5_4/gui/.qmake.stash
Project ERROR: Unknown module(s) in QT: webenginewidgets
*** Error code 3

Do you have any other tips to try?
Comment 3 Miroslav Lachman 2019-02-21 19:34:27 UTC
Created attachment 202238 [details]
poudriere build failure full log

cd gui ; qmake app.pro && make
Info: creating stash file /wrkdirs/usr/ports/astro/gpsbabel/work/gpsbabel-gpsbabel_1_5_4/gui/.qmake.stash
Project ERROR: Unknown module(s) in QT: webenginewidgets
*** Error code 3
Comment 4 Oliver Heesakkers 2019-02-27 18:58:31 UTC
Still working on this. I ran out of disk space though on my virtual poudriere-box, so 'm going to have to re-purpose some old hardware.

It probably has something to do with the GUI_USE lines not having the right arguments. I hope to have an update this weekend.
Comment 5 Oliver Heesakkers 2019-03-10 11:22:09 UTC
Created attachment 202771 [details]
proposed patch to Makefile

Attached proposed patch.

Poudriere log (amd64 only) here:
https://heesakkers.info/showandtell/gpsbabel-1.5.4_3.log

Resulting package (for 12) here:
https://heesakkers.info/showandtell/gpsbabel-1.5.4_3.txz
Comment 6 Miroslav Lachman 2019-03-10 13:44:31 UTC
Confirmed. Builds fine for me.

[00:00:12] [01] [00:00:00] Building astro/gpsbabel | gpsbabel-1.5.4_3
[00:04:41] [01] [00:04:29] Finished astro/gpsbabel | gpsbabel-1.5.4_3: Success
Comment 7 Oliver Heesakkers 2019-03-10 15:45:05 UTC
But more importantly: does it run? (the GUI specifically)
Comment 8 Miroslav Lachman 2019-03-10 16:34:19 UTC
I am sorry, I cannot test the run now. My desktop is still at 10.4. I need to fix some other packages to build and then I will try to upgrade my desktop to 11.2 and run test all these packages. 
I hope I will let you know soon. (maybe 2 weeks)
Comment 9 Tilman Keskinoz freebsd_committer freebsd_triage 2019-03-19 20:46:00 UTC
committed, thanks
Comment 10 commit-hook freebsd_committer freebsd_triage 2019-03-19 20:46:24 UTC
A commit references this bug:

Author: arved
Date: Tue Mar 19 20:45:44 UTC 2019
New revision: 496294
URL: https://svnweb.freebsd.org/changeset/ports/496294

Log:
  Fix build after QT4 removal

  PR:		235919
  Submitted by:	maintainer
  Reported by:	Miroslav Lachman

Changes:
  head/astro/gpsbabel/Makefile