Bug 235960 - net-mgmt/smokeping: reference correct GH_TAGNAME to fetch 2.7.3
Summary: net-mgmt/smokeping: reference correct GH_TAGNAME to fetch 2.7.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-23 12:54 UTC by Michael Lyngbol
Modified: 2019-02-27 07:13 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (rodrigo)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Lyngbol 2019-02-23 12:54:48 UTC
Hi,

Reference correct github commit to fetch smokeping 2.7.3.

Current tag will fetch 2.7.0

/Michael


diff --git a/net-mgmt/smokeping/Makefile b/net-mgmt/smokeping/Makefile
index d202f758986e..f8a586e945f4 100644
--- a/net-mgmt/smokeping/Makefile
+++ b/net-mgmt/smokeping/Makefile
@@ -78,7 +78,7 @@ DNS_RUN_DEPENDS=      p5-Net-DNS>=0:dns/p5-Net-DNS
 USE_GITHUB=    yes
 GH_ACCOUNT=    oetiker
 GH_PROJECT=    SmokePing
-GH_TAGNAME=    9b2ecb9
+GH_TAGNAME=    0992229

 # We will take these from CPAN instead
 post-extract:
diff --git a/net-mgmt/smokeping/distinfo b/net-mgmt/smokeping/distinfo
index fc114aa54189..b3e1e30b5124 100644
--- a/net-mgmt/smokeping/distinfo
+++ b/net-mgmt/smokeping/distinfo
@@ -1,3 +1,3 @@
-TIMESTAMP = 1548858797
-SHA256 (oetiker-SmokePing-2.7.3-9b2ecb9_GH0.tar.gz) = 10ff209c4efae212b5347ffdcda100a536f690ee154211e54e0d01c5d5508401
-SIZE (oetiker-SmokePing-2.7.3-9b2ecb9_GH0.tar.gz) = 317527
+TIMESTAMP = 1550925708
+SHA256 (oetiker-SmokePing-2.7.3-0992229_GH0.tar.gz) = 77753b2ed74f7d16b5c492d908e0f95ec7dc4acfecbacc47972238b6bb7d7be5
+SIZE (oetiker-SmokePing-2.7.3-0992229_GH0.tar.gz) = 323158
Comment 1 Tobias Kortkamp freebsd_committer 2019-02-23 12:59:52 UTC
GH_TAGNAME can (and should be) dropped entirely here, if 0992229 matches the
upstream tag 2.7.3.
Comment 2 Michael Lyngbol 2019-02-23 13:08:22 UTC
Remove GH_TAGNAME as PORTVERSION=2.7.3 simply will fetch git tag 2.7.3

git commit 0992229 matches git tag 2.7.3

Add PORTREVISION=1

/Michael


diff --git a/net-mgmt/smokeping/Makefile b/net-mgmt/smokeping/Makefile
index d202f758986e..c26970032b20 100644
--- a/net-mgmt/smokeping/Makefile
+++ b/net-mgmt/smokeping/Makefile
@@ -3,6 +3,7 @@

 PORTNAME=      smokeping
 PORTVERSION=   2.7.3
+PORTREVISION=  1
 CATEGORIES=    net-mgmt www

 MAINTAINER=    rodrigo@FreeBSD.org
@@ -78,7 +79,6 @@ DNS_RUN_DEPENDS=      p5-Net-DNS>=0:dns/p5-Net-DNS
 USE_GITHUB=    yes
 GH_ACCOUNT=    oetiker
 GH_PROJECT=    SmokePing
-GH_TAGNAME=    9b2ecb9

 # We will take these from CPAN instead
 post-extract:
diff --git a/net-mgmt/smokeping/distinfo b/net-mgmt/smokeping/distinfo
index fc114aa54189..33ff90f6a72f 100644
--- a/net-mgmt/smokeping/distinfo
+++ b/net-mgmt/smokeping/distinfo
@@ -1,3 +1,3 @@
-TIMESTAMP = 1548858797
-SHA256 (oetiker-SmokePing-2.7.3-9b2ecb9_GH0.tar.gz) = 10ff209c4efae212b5347ffdcda100a536f690ee154211e54e0d01c5d5508401
-SIZE (oetiker-SmokePing-2.7.3-9b2ecb9_GH0.tar.gz) = 317527
+TIMESTAMP = 1550926978
+SHA256 (oetiker-SmokePing-2.7.3_GH0.tar.gz) = 6bd90e9a9c44a03789519cf21bd2c977476f0c11267fd55f7d14015f92b93a05
+SIZE (oetiker-SmokePing-2.7.3_GH0.tar.gz) = 323143
Comment 3 Tobias Kortkamp freebsd_committer 2019-02-27 06:00:04 UTC
Thanks, this looks fine to me.

Can you attach the patch here?  Inline patches posted on Bugzilla have
broken whitespace and are hard and annoying to apply.

I can commit this end of next week if rodrigo@ does not do it sooner.
Comment 4 Rodrigo Osorio freebsd_committer 2019-02-27 06:30:35 UTC
Sorry for the tag error, i'm currently testing it.
If everything goes fine the fix will be committed today
Comment 5 commit-hook freebsd_committer 2019-02-27 07:08:20 UTC
A commit references this bug:

Author: rodrigo
Date: Wed Feb 27 07:08:05 UTC 2019
New revision: 494027
URL: https://svnweb.freebsd.org/changeset/ports/494027

Log:
  Remove GH_TAGNAME who points to v2.7.0 instead of v2.7.3

  Add new files in plist
  Bump portrevision

  PR:		235960
  Reported by:	Michael Lyngbol <michael@lyngbol.dk>

Changes:
  head/net-mgmt/smokeping/Makefile
  head/net-mgmt/smokeping/distinfo
  head/net-mgmt/smokeping/pkg-plist
Comment 6 Rodrigo Osorio freebsd_committer 2019-02-27 07:09:00 UTC
Committed, thanks.
Comment 7 Tobias Kortkamp freebsd_committer 2019-02-27 07:13:44 UTC
Thank you.