Bug 236047 - www/seahub: possible regression when calling /api2/search-user/
Summary: www/seahub: possible regression when calling /api2/search-user/
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords: needs-qa, regression
Depends on:
Blocks:
 
Reported: 2019-02-26 09:50 UTC by Martin Waschbüsch
Modified: 2019-03-16 18:00 UTC (History)
1 user (show)

See Also:
ultima: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Waschbüsch 2019-02-26 09:50:07 UTC
On a current seafile install, I go to

System Admin => Libraries

and then for any library open the Share dialog.

In the search field, I can enter a username or email to search for a user to share the library with, but I always get a 'Loading failed' error.
The corresponding error in seahub.log is:

2019-02-25 17:35:06,946 [ERROR] django.request:135 handle_uncaught_exception Internal Server Error: /api2/search-user/
Traceback (most recent call last):
 File "/usr/local/lib/python2.7/site-packages/django/core/handlers/exception.py", line 41, in inner
   response = get_response(request)
 File "/usr/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 249, in _legacy_get_response
   response = self._get_response(request)
 File "/usr/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 187, in _get_response
   response = self.process_exception_by_middleware(e, request)
 File "/usr/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 185, in _get_response
   response = wrapped_callback(request, *callback_args, **callback_kwargs)
 File "/usr/local/lib/python2.7/site-packages/django/views/decorators/csrf.py", line 58, in wrapped_view
   return view_func(*args, **kwargs)
 File "/usr/local/lib/python2.7/site-packages/django/views/generic/base.py", line 68, in view
   return self.dispatch(request, *args, **kwargs)
 File "/usr/local/lib/python2.7/site-packages/rest_framework/views.py", line 495, in dispatch
   response = self.handle_exception(exc)
 File "/usr/local/lib/python2.7/site-packages/rest_framework/views.py", line 455, in handle_exception
   self.raise_uncaught_exception(exc)
 File "/usr/local/lib/python2.7/site-packages/rest_framework/views.py", line 492, in dispatch
   response = handler(request, *args, **kwargs)
 File "/usr/local/www/haiwen/seafile-server/seahub/seahub/api2/endpoints/search_user.py", line 129, in get
   user_obj_list = ccnet_api.get_emailusers_in_list('DB', email_list_json) + \
AttributeError: 'CcnetAPI' object has no attribute 'get_emailusers_in_list'

The package versions are:

libsearpc-3.1.0,1
py27-seafdav-6.3.11
py27-seafobj-6.3.11
seafile-server-6.3.4_1
seahub-6.3.11


Now, I have an older installation still running

libsearpc-3.0.8_1,1
py27-seafdav-6.3.7
py27-seafobj-6.3.7
seafile-server-6.3.4_1
seahub-6.3.7_1

but otherwise the same config (webserver, seahub_settings, etc.) which does not show the issue.

Could this be a bug in the most recent version?
Comment 1 Martin Waschbüsch 2019-02-26 09:51:19 UTC
ultima@ suggested that it may be related to
https://github.com/haiwen/seahub/pull/2633/commits/4bd9c13927151b7c7688153d24552bf6d97c0a04
I also raised the issue upstream on github: https://github.com/haiwen/seahub/issues/3001
Comment 2 Richard Gallamore freebsd_committer 2019-03-16 17:14:05 UTC
This is a regression but my inital scan was incorrect. The regression is actually [1].

[1] https://github.com/haiwen/seahub/commit/496b1c955f24be4ccaa285c70d4bed9794ca70c4
Comment 3 commit-hook freebsd_committer 2019-03-16 18:00:14 UTC
A commit references this bug:

Author: ultima
Date: Sat Mar 16 17:59:43 UTC 2019
New revision: 495933
URL: https://svnweb.freebsd.org/changeset/ports/495933

Log:
  * Updated to 6.3.13
  * Added patch to SeaHub to revert regression

  The regression breaks the search_user function.
  More details about regression can be found at:
  https://github.com/haiwen/seahub/issues/3001

  PR:		236047
  Reported by:	Martin Waschb?sch <martin@wasch^>

Changes:
  head/net-mgmt/seafile-server/Makefile.include
  head/www/py-seafdav/distinfo
  head/www/py-seafobj/distinfo
  head/www/seahub/Makefile
  head/www/seahub/distinfo
  head/www/seahub/files/patch-seahub_api2_endpoints_search__user.py
  head/www/seahub/pkg-plist