Bug 236061 - devel/json-cpp: Fix build with libc++ 8.0
Summary: devel/json-cpp: Fix build with libc++ 8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks: 236062
  Show dependency treegraph
 
Reported: 2019-02-26 18:20 UTC by Dimitry Andric
Modified: 2019-02-27 21:51 UTC (History)
2 users (show)

See Also:


Attachments
Comment out line that produces "-I." (1.02 KB, patch)
2019-02-26 18:20 UTC, Dimitry Andric
yuri: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer 2019-02-26 18:20:06 UTC
Created attachment 202389 [details]
Comment out line that produces "-I."

With libc++ 8.0, which is in the projects/clang800-import branch, and which will soon be merged to head, compilation of devel/jsoncpp fails due to a conflict between the new C++ <version> header, and a local file "version" which is produced by jsoncpp during its configure phase.

This is due to the initial test runner being compiled with "-I.", even though it does not need any file from the port's working directory root.  Therefore, it seems to be easiest to comment out the line from the SConstruct script that adds the "-I." option.
Comment 1 Yuri Victorovich freebsd_committer 2019-02-26 19:01:43 UTC
Dimitry,

I wouldn't have time for this any time soon.
Please commit it as long as it doesn't break anything.

Thanks,
Yuri
Comment 2 commit-hook freebsd_committer 2019-02-26 19:09:38 UTC
A commit references this bug:

Author: dim
Date: Tue Feb 26 19:08:43 UTC 2019
New revision: 493979
URL: https://svnweb.freebsd.org/changeset/ports/493979

Log:
  With libc++ 8.0, which is in the projects/clang800-import branch, and
  which will soon be merged to head, compilation of devel/jsoncpp fails
  due to a conflict between the new C++ <version> header, and a local file
  "version" which is produced by jsoncpp during its configure phase.

  This is due to the initial test runner being compiled with "-I.", even
  though it does not need any file from the port's working directory root.
  Therefore, it seems to be easiest to comment out the line from the
  SConstruct script that adds the "-I." option.

  Approved by:	yuri (maintainer)
  PR:		236061
  MFH:		2019Q1

Changes:
  head/devel/jsoncpp/Makefile
  head/devel/jsoncpp/files/patch-SConstruct
Comment 3 Dimitry Andric freebsd_committer 2019-02-26 19:18:36 UTC
Thanks Yuri, I committed the fix, and requested an MFH.
Comment 4 Yuri Victorovich freebsd_committer 2019-02-26 19:41:06 UTC
(In reply to Dimitry Andric from comment #3)

Thank you!
Comment 5 commit-hook freebsd_committer 2019-02-27 21:51:15 UTC
A commit references this bug:

Author: dim
Date: Wed Feb 27 21:50:17 UTC 2019
New revision: 494088
URL: https://svnweb.freebsd.org/changeset/ports/494088

Log:
  MFH: r493979

  With libc++ 8.0, which is in the projects/clang800-import branch, and
  which will soon be merged to head, compilation of devel/jsoncpp fails
  due to a conflict between the new C++ <version> header, and a local file
  "version" which is produced by jsoncpp during its configure phase.

  This is due to the initial test runner being compiled with "-I.", even
  though it does not need any file from the port's working directory root.
  Therefore, it seems to be easiest to comment out the line from the
  SConstruct script that adds the "-I." option.

  Approved by:	portmgr (joneum)
  PR:		236061

Changes:
_U  branches/2019Q1/
  branches/2019Q1/devel/jsoncpp/Makefile
  branches/2019Q1/devel/jsoncpp/files/patch-SConstruct