Bug 236098 - [PATCH] net-mgmt/mk-livestatus: fix build with GCC-based architectures
Summary: [PATCH] net-mgmt/mk-livestatus: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vinícius Zavam
URL: https://reviews.freebsd.org/D19364
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-02-28 06:30 UTC by Piotr Kubaj
Modified: 2019-03-06 13:41 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (egypcio)


Attachments
patch (275 bytes, patch)
2019-02-28 06:30 UTC, Piotr Kubaj
no flags Details | Diff
ports_r494133_PATCH__net-mgmt_mk-livestatus.diff (2.50 KB, patch)
2019-02-28 08:32 UTC, Vinícius Zavam
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2019-02-28 06:30:48 UTC
Created attachment 202431 [details]
patch

Since last update, this port requires C++11-compatible compiler. Add USES=compiler:c++11-lang to fix build on GCC architectures.

Tested on powerpc64 and amd64.

Hardware sponsored by IntegriCloud.
Comment 1 Vinícius Zavam freebsd_committer 2019-02-28 08:14:43 UTC
(In reply to Piotr Kubaj from comment #0)

Hey! Hi Piotr,
how re you doing? :)

Thank you for the patch. Very appreciated! From now on I should have a better testing setup/scenario for testing GCC-related stuff :)

I'll merge your patch to a new one that also updates this port's version. Sound good for you?

TYVM! KR,
Comment 2 Vinícius Zavam freebsd_committer 2019-02-28 08:32:57 UTC
Created attachment 202437 [details]
ports_r494133_PATCH__net-mgmt_mk-livestatus.diff

attaching the proposed patch to land.
once again: TYVM for the time and concern sharing your patch :)

KR,
Comment 3 Piotr Kubaj freebsd_committer 2019-02-28 10:27:41 UTC
(In reply to Vinícius Zavam from comment #1)
Hm, I'm fine thanks. How are you?

BTW, do we know each other from somewhere? I can't recall you :)
Comment 4 Vinícius Zavam freebsd_committer 2019-02-28 13:57:18 UTC
(In reply to Piotr Kubaj from comment #3)

AFAIK, we do not know each other AFK. only over Bugzilla :)
I did merged and commit some other patches you wrote before.
Comment 5 commit-hook freebsd_committer 2019-03-06 12:49:43 UTC
A commit references this bug:

Author: egypcio
Date: Wed Mar  6 12:49:34 UTC 2019
New revision: 494795
URL: https://svnweb.freebsd.org/changeset/ports/494795

Log:
  net-mgmt/mk-livestatus: update 1.2.8p24 to 1.2.8p25

    - while here, merge PR 236098.

  PR:	236098
  Submitted by:	Piotr Kubaj <pkubaj % anongoth.pl>
  Approved by:	rene (mentor)
  Sponsored by:	IntegriCloud
  Differential Revision:	https://reviews.freebsd.org/D19364

Changes:
  head/net-mgmt/mk-livestatus/Makefile
  head/net-mgmt/mk-livestatus/distinfo
Comment 6 Vinícius Zavam freebsd_committer 2019-03-06 13:41:07 UTC
committed! thanks :)