Bug 236108 - [patch] astro/xtide: update to 2.15.2; update MASTER_SITES; add missing dependencies
Summary: [patch] astro/xtide: update to 2.15.2; update MASTER_SITES; add missing depen...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-28 14:03 UTC by Samy Mahmoudi
Modified: 2019-03-05 22:33 UTC (History)
0 users

See Also:


Attachments
Patch file generated with svn diff (2.54 KB, patch)
2019-02-28 14:03 UTC, Samy Mahmoudi
no flags Details | Diff
Poudriere log (156.56 KB, text/plain)
2019-02-28 14:41 UTC, Samy Mahmoudi
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Samy Mahmoudi 2019-02-28 14:03:08 UTC
astro/xtide: update to 2.15.2

Update astro/xtide to 2.15.2.

These release fixes two bugs and prevents software rot.

While here:
- Update MASTER_SITES to follow upstream migration from ftp to https
- Add missing dependencies
- Reorder section blocks to pet portlint

Changelog:
https://flaterco.com/xtide/changelog.html
Comment 1 Samy Mahmoudi 2019-02-28 14:03:18 UTC
Created attachment 202440 [details]
Patch file generated with svn diff
Comment 2 Samy Mahmoudi 2019-02-28 14:41:03 UTC
Created attachment 202442 [details]
Poudriere log
Comment 3 Samy Mahmoudi 2019-02-28 14:48:35 UTC
Please note that a trailing space was left unseen in distinfo (I have configured vim to highlight such things).

Without that information, lines 60-61 of the patch may raise a security concern, or do not make sense.
Comment 4 commit-hook freebsd_committer 2019-03-05 21:58:19 UTC
A commit references this bug:

Author: fernape
Date: Tue Mar  5 21:57:39 UTC 2019
New revision: 494749
URL: https://svnweb.freebsd.org/changeset/ports/494749

Log:
  astro/xtide: update MASTER_SITES, general cleanup

  * Update MASTER_SITES to follow upstream migration from ftp to https
  * Add missing dependencies
  * Reorder section blocks to pet portlint

  PR:	236108
  Submitted by:	samy.mahmoudi@gmail.com

Changes:
  head/astro/xtide/Makefile
Comment 5 Fernando Apesteguía freebsd_committer 2019-03-05 22:00:08 UTC
Thanks for the patch Samy.

Notice that I separatedly updated the port to 2.15.2 in r494518 so now I added the new bits from your patch.

Thanks again!
Comment 6 Samy Mahmoudi 2019-03-05 22:33:31 UTC
(In reply to Fernando Apesteguía from comment #5)

Perfect, as I had not noticed your update.