Bug 236175 - x11/terminator: upgrade to 1.0
Summary: x11/terminator: upgrade to 1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2019-03-03 06:34 UTC by Hajimu UMEMOTO
Modified: 2019-03-31 17:52 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback-


Attachments
Patch to upgrade x11/terminator to 1.0 (7.49 KB, patch)
2019-03-03 06:34 UTC, Hajimu UMEMOTO
no flags Details | Diff
Update to 1.0, revised patch (8.20 KB, patch)
2019-03-18 20:13 UTC, Thomas Zander
riggs: maintainer-approval? (tom)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajimu UMEMOTO freebsd_committer 2019-03-03 06:34:34 UTC
Created attachment 202516 [details]
Patch to upgrade x11/terminator to 1.0

Here is a patch to upgrade x11/terminator to Terminator 1.0.
It seems 1.0 is the latest version of Terminator which uses GTK2.
The latest Terminator is 1.91.  It is better to upgrade x11/terminator
to the latest one.  However, since it has been moved to use GTK3, it
seems not easy to upgrade to 1.91.
Comment 1 Thomas Zander freebsd_committer 2019-03-17 18:02:16 UTC
Double-checking builds ...
Comment 2 Thomas Zander freebsd_committer 2019-03-18 20:13:24 UTC
Created attachment 202962 [details]
Update to 1.0, revised patch

This fixes a build failure when NLS disabled and the pre-patch target to change the libc name which apparently was adopted upstream.
Comment 3 Thomas Zander freebsd_committer 2019-03-31 17:38:23 UTC
Feedback timeout
Comment 4 commit-hook freebsd_committer 2019-03-31 17:40:28 UTC
A commit references this bug:

Author: riggs
Date: Sun Mar 31 17:39:55 UTC 2019
New revision: 497437
URL: https://svnweb.freebsd.org/changeset/ports/497437

Log:
  Update to upstream release 1.0

  PR:		236175
  Submitted by:	ume

Changes:
  head/x11/terminator/Makefile
  head/x11/terminator/distinfo
  head/x11/terminator/pkg-plist