Bug 236212 - devel/catch: fails to build with clang 8
Summary: devel/catch: fails to build with clang 8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pietro Cerutti
URL:
Keywords: needs-patch
Depends on:
Blocks: 236062
  Show dependency treegraph
 
Reported: 2019-03-04 13:14 UTC by Jan Beich
Modified: 2019-03-04 15:07 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (gahr)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2019-03-04 13:14:41 UTC
$ poudriere jail -cj clang8 -v projects/clang800-import -m svn+https
$ poudriere testport -j clang8 devel/catch
[...]
In file included from include/internal/catch_assertionhandler.cpp:17:
In file included from include/internal/catch_run_context.h:13:
include/internal/catch_interfaces_reporter.h:83:25: error: explicitly defaulted copy assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
        AssertionStats& operator = ( AssertionStats const& ) = default;
                        ^
include/internal/catch_interfaces_reporter.h:87:25: note: copy assignment operator of 'AssertionStats' is implicitly deleted because field 'assertionResult' has a deleted copy assignment operator
        AssertionResult assertionResult;
                        ^
include/internal/catch_assertionresult.h:54:29: note: copy assignment operator of 'AssertionResult' is implicitly deleted because field 'm_resultData' has a deleted copy assignment operator
        AssertionResultData m_resultData;
                            ^
include/internal/catch_assertionresult.h:28:24: note: copy assignment operator of 'AssertionResultData' is implicitly deleted because field 'lazyExpression' has a deleted copy assignment operator
        LazyExpression lazyExpression;
                       ^
include/internal/catch_assertionhandler.h:32:25: note: 'operator=' has been explicitly marked deleted here
        LazyExpression& operator = ( LazyExpression const& ) = delete;
                        ^
In file included from include/internal/catch_assertionhandler.cpp:17:
In file included from include/internal/catch_run_context.h:13:
include/internal/catch_interfaces_reporter.h:84:25: error: explicitly defaulted move assignment operator is implicitly deleted [-Werror,-Wdefaulted-function-deleted]
        AssertionStats& operator = ( AssertionStats && )     = default;
                        ^
include/internal/catch_interfaces_reporter.h:87:25: note: move assignment operator of 'AssertionStats' is implicitly deleted because field 'assertionResult' has a deleted move assignment operator
        AssertionResult assertionResult;
                        ^
include/internal/catch_assertionresult.h:54:29: note: copy assignment operator of 'AssertionResult' is implicitly deleted because field 'm_resultData' has a deleted copy assignment operator
        AssertionResultData m_resultData;
                            ^
include/internal/catch_assertionresult.h:28:24: note: copy assignment operator of 'AssertionResultData' is implicitly deleted because field 'lazyExpression' has a deleted copy assignment operator
        LazyExpression lazyExpression;
                       ^
include/internal/catch_assertionhandler.h:32:25: note: 'operator=' has been explicitly marked deleted here
        LazyExpression& operator = ( LazyExpression const& ) = delete;
                        ^
2 errors generated.

http://package18.nyi.freebsd.org/data/headamd64PR236062-default/2019-03-01_06h42m53s/logs/errors/catch-2.6.1.log
Comment 1 Pietro Cerutti freebsd_committer freebsd_triage 2019-03-04 15:02:25 UTC
This was fixed upstream: 
https://github.com/catchorg/Catch2/commit/e8bfd882e8e8738d884933ad75eb25e8a50989b8
Comment 2 commit-hook freebsd_committer freebsd_triage 2019-03-04 15:07:07 UTC
A commit references this bug:

Author: gahr
Date: Mon Mar  4 15:06:03 UTC 2019
New revision: 494599
URL: https://svnweb.freebsd.org/changeset/ports/494599

Log:
  devel/catch: fix build with clang 8

  PR:		236212
  Submitted by:	jbeich
  Obtained from:	https://github.com/catchorg/Catch2/pull/1537

Changes:
  head/devel/catch/files/
  head/devel/catch/files/patch-bug236212