Bug 236232 - mail/gmime26: missing plist entries if gobject-introspection installed
Summary: mail/gmime26: missing plist entries if gobject-introspection installed
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-04 22:06 UTC by John Hein
Modified: 2019-03-08 00:22 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bofh)


Attachments
[patch] explicitly disable introspection (422 bytes, patch)
2019-03-04 22:06 UTC, John Hein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2019-03-04 22:06:25 UTC
Created attachment 202566 [details]
[patch] explicitly disable introspection

'make -C  /usr/ports/mail/gmime26 stage-qa check-plist' gives the following if the gobject-introspection port is installed (and thus detected at configure time):

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/girepository-1.0/GMime-2.6.typelib
Error: Orphaned: share/gir-1.0/GMime-2.6.gir
Error: Orphaned: share/vala/vapi/gmime-2.6.deps
Error: Orphaned: share/vala/vapi/gmime-2.6.vapi


Fix attached: explicitly disable introspection which should agree with current package builds (presumably build in a poudriere environment without gobject-introspection installed).  No need to bump PORTREVISION, I believe.

Another option would be to add introspection:build to USE_GNOME and add the entries to the plist (more work, but that would benefit those that might use the introspection files).  That would suggest a PORTREVISION bump.

QA:
 - poudriere (11/amd64 ok - gmime26 & gmime26-sharp)
 - portlint (no new warnings)
Comment 1 commit-hook freebsd_committer 2019-03-06 19:13:05 UTC
A commit references this bug:

Author: bofh
Date: Wed Mar  6 19:12:50 UTC 2019
New revision: 494832
URL: https://svnweb.freebsd.org/changeset/ports/494832

Log:
  mail/gmime26: Fix build if gobject-introspection installed

  PR:		236232
  Submitted by:	jcfyecrayz@liamekaens.com

Changes:
  head/mail/gmime26/Makefile
  head/mail/gmime26/files/patch-docs_Makefile.in
  head/mail/gmime26/pkg-plist
Comment 2 John Hein 2019-03-08 00:22:52 UTC
(In reply to commit-hook from comment #1)
Thanks.
Do you want to apply the same options to gmime30?