Bug 236259 - [PATCH] net-im/libsignon-glib: add GTKDOC option
Summary: [PATCH] net-im/libsignon-glib: add GTKDOC option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-kde (Team)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-05 15:54 UTC by rozhuk.im
Modified: 2019-03-10 14:19 UTC (History)
3 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
gtkdoc opt (5.36 KB, patch)
2019-03-05 15:54 UTC, rozhuk.im
tcberner: maintainer-approval-
Details | Diff
gtkdoc opt (5.51 KB, patch)
2019-03-05 21:35 UTC, rozhuk.im
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rozhuk.im 2019-03-05 15:54:44 UTC
Created attachment 202589 [details]
gtkdoc opt
Comment 1 Tobias C. Berner freebsd_committer 2019-03-05 18:25:44 UTC
Moin moin

Could you elaborate why you don't want the docs :)

Also, requires portrevision bump.

mfg Tobias
Comment 2 rozhuk.im 2019-03-05 18:37:22 UTC
(In reply to Tobias C. Berner from comment #1)

Im never use docs that installed with ports.
Are you sure about portrevision bump?
Comment 3 Tobias C. Berner freebsd_committer 2019-03-05 18:39:56 UTC
(In reply to rozhuk.im from comment #2)
What I wanted to bring across is: bug reports are better with text :-)
Comment 4 rozhuk.im 2019-03-05 21:35:57 UTC
Created attachment 202619 [details]
gtkdoc opt

bump port revision
Comment 5 commit-hook freebsd_committer 2019-03-10 14:17:05 UTC
A commit references this bug:

Author: adridg
Date: Sun Mar 10 14:16:14 UTC 2019
New revision: 495294
URL: https://svnweb.freebsd.org/changeset/ports/495294

Log:
  Add DOCS option to net-im/libsignon-glib.

  This makes the documentation optional (but defaults to on). Without
  the documentation, no gtkdoc needs to be built, and no Doxygen gets
  dragged in.

  The ports framework for --enable-<foo> doesn't help here, because that
  option is created by the gtkdoc autoconf macros, which we don't want
  to have involved. Use sed to comment out the offending bits. Patch
  considerably changed from the PR.

  PORTREVISION bumped because there's now options where there were
  none before, but the default package doesn't change at all.

  PR:		236259
  Reported by:	rozhuk.im@gmail.com

Changes:
  head/net-im/libsignon-glib/Makefile
  head/net-im/libsignon-glib/pkg-plist
Comment 6 Adriaan de Groot freebsd_committer 2019-03-10 14:19:36 UTC
Committed with major changes.