Bug 236287 - [PATCH] deskutils/gucharmap: remove build dep: textproc/gtk-doc
Summary: [PATCH] deskutils/gucharmap: remove build dep: textproc/gtk-doc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome mailing list
Depends on:
Reported: 2019-03-05 17:54 UTC by rozhuk.im
Modified: 2020-03-14 04:24 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gnome)

remove build dep (876 bytes, patch)
2019-03-05 17:54 UTC, rozhuk.im
rozhuk.im: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rozhuk.im 2019-03-05 17:54:15 UTC
Created attachment 202600 [details]
remove build dep
Comment 1 Ting-Wei Lan 2019-03-10 04:55:51 UTC
(In reply to rozhuk.im from comment #0)
Why it should be removed instead of being added as an option? I just checked the master branch and it does have gtk-doc documentation.
Comment 2 rozhuk.im 2019-03-10 05:01:35 UTC
(In reply to Ting-Wei Lan from comment #1)
Looks like it does not used in build process, probably upstream use it before create dist.
Comment 3 Ting-Wei Lan 2019-03-10 05:07:53 UTC
(In reply to rozhuk.im from comment #2)
Did you pass --enable-gtk-doc to the configure script?
Comment 4 rozhuk.im 2019-03-10 05:14:39 UTC
(In reply to Ting-Wei Lan from comment #3)
No, I only change Makefile to remove gtk-doc staff and run:
make package
it found all files that included in pkg-plist, no errors.
Comment 5 Ting-Wei Lan 2019-03-10 05:29:07 UTC
(In reply to rozhuk.im from comment #4)
Isn't it better to add gtk-doc files to pkg-plist under GTKDOC option instead of trying to disabling it with sed? Adding sed commands to Makefile looks unnecessary in this case if it works by keeping BUILD_DEPENDS on gtk-doc.
Comment 6 rozhuk.im 2019-03-10 05:41:47 UTC
(In reply to Ting-Wei Lan from comment #5)
It can not be build without patching via sed.

I dont know what this port want to do with gtk-doc, I just want to not install gtk-doc during build ports, so I add GTKDOC option, rename doc->gtk-doc option an remove unused gtk-doc dep in almost all ports in tree.

If you want to extend this port - feel free to update patch :)
Another good option to add is DOCS, to allow install all share/help staff.
Comment 7 Ting-Wei Lan 2019-03-10 11:10:46 UTC
(In reply to rozhuk.im from comment #6)
Why installing gtk-doc is a problem? The reason that gtk-doc was needed is that the upstream didn't publish a release tarball for version 11.0.1. The update to version 11.0.1 was required because old versions didn't build after textproc/UCD was updated to Unicode version 11.0. Therefore, we switched the gucharmap port to use GNOME GitLab in order to fix the build, and gtk-doc became required because we had to generate the configure script from sources.

Now gucharmap 11.0.2 and 11.0.3 release tarballs are available, we should be able to switch back to release tarballs and drop gtk-doc build dependency.
Comment 8 rozhuk.im 2020-03-14 04:24:12 UTC
Will wait 11.0.3+ to fix this.