Created attachment 202667 [details]
Should be a pretty routine update. This is my first update to a port, so if I missed something from the porter's handbook, then feedback is very welcome!
Generally, before submitting patch,
- verify the port using portlint
- verify pkg-plist have no orphaned/missing files
To verify pkg-plist, you can use poudriere but it is a little bit difficult to setup. `make clean stage check-orphans` is enough.
Regarding this patch,
- reset PORTREVISION to 0 when updating PORTVERSION
- PORTREVISION=0 line is not necessary so simply remove it
- PLIST_FILES is incorrect, some files orphaned
I'll fix on my side and commit it at this time.
A commit references this bug:
Date: Sat Mar 9 03:15:10 UTC 2019
New revision: 495095
net/eternalterminal: Update to 5.1.9
Submitted by: Trevis <firstname.lastname@example.org> (maintainer)
(In reply to Koichiro Iwao from comment #1)
Thank you for the feedback! Thought I had run portlint, and the way to verify pkg-plist is very useful .
Really appreciate that you took the time to clean up the patch. Hope to become a high value contributor and getting helpful feedback, especially so quickly, is awesome!
(In reply to Trevis from comment #4)
Nobody's perfect from the beginning including myself. Keep going! :)