Bug 236382 - x11/alacritty: Fix SpawnNewInstance on FreeBSD
Summary: x11/alacritty: Fix SpawnNewInstance on FreeBSD
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-03-08 03:11 UTC by Tobias Kortkamp
Modified: 2019-03-22 12:31 UTC (History)
1 user (show)

See Also:
tobik: maintainer-feedback-


Attachments
alacritty.diff (1.62 KB, patch)
2019-03-08 03:11 UTC, Tobias Kortkamp
tobik: maintainer-approval? (zeising)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-08 03:11:25 UTC
Created attachment 202706 [details]
alacritty.diff

Add [1] to the port to fix SpawnNewInstance.  On Linux it looks up
/proc/$shell_pid/cwd to open the new instance in the same working
directory which doesn't work on FreeBSD.  On FreeBSD we can fallback
to /compat/linux for now.

[1] https://github.com/jwilm/alacritty/pull/2162
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-03-22 12:30:31 UTC
A commit references this bug:

Author: tobik
Date: Fri Mar 22 12:29:37 UTC 2019
New revision: 496561
URL: https://svnweb.freebsd.org/changeset/ports/496561

Log:
  x11/alacritty: Apply workaround to let SpawnNewInstance work on FreeBSD

  On Linux Alacritty looks up /proc/$shell_pid/cwd to open new instances
  in the same working directory as the old instance which does not
  work with FreeBSD's procfs(5).  As a workaround we can for now
  fallback to linprocfs(5), often mounted on /compat/linux/proc, until
  there is support for KERN_PROC_CWD and struct kinfo_file in the
  Rust ecosystem (libc or elsewhere).

  PR:		236382
  Submitted by:	tobik
  Approved by:	zeising (maintainer timeout, 2 weeks)

Changes:
  head/x11/alacritty/Makefile
  head/x11/alacritty/files/
  head/x11/alacritty/files/patch-src_event.rs