Bug 236445 - sysutils/consolekit2: Make ck-system-* scripts user editable
Summary: sysutils/consolekit2: Make ck-system-* scripts user editable
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-03-10 09:31 UTC by Tobias Kortkamp
Modified: 2019-03-25 07:52 UTC (History)
3 users (show)

See Also:
tobik: maintainer-feedback-


Attachments
consolekit2.diff (1.55 KB, patch)
2019-03-10 09:31 UTC, Tobias Kortkamp
tobik: maintainer-approval? (gnome)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-10 09:31:02 UTC
Created attachment 202768 [details]
consolekit2.diff

It would be nice if the ck-system-* scripts could be user editable.  This
is for example needed when using sysutils/runit-faster as pid 1
which does not react well to signals send by shutdown(8)/reboot(8)/halt(8)
and where you have to use runit-init {0,6} to shutdown/reboot the
system.  At the moment the Xfce4 logout dialog is just broken in
that case and there is no way to edit the ck-system-* scripts without
it being overwritten during updates.
Comment 1 Olivier Duchateau 2019-03-11 17:32:23 UTC
(In reply to Tobias Kortkamp from comment #0)

About Xfce logout. It works fine without ConsoleKit2 (there is fallback mode, not enable by default).
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2019-03-11 17:48:36 UTC
(In reply to Olivier Duchateau from comment #1)
> (In reply to Tobias Kortkamp from comment #0)
> 
> About Xfce logout. It works fine without ConsoleKit2 (there is fallback
> mode, not enable by default).

Problem is that this fallback calls shutdown(8) too AFAICT.  Worse
it is hardcoded and changing it would require recompiling xfce4-session
(see xfsm-shutdown-helper/main.c) since the shutdown command isn't
a runtime configurable option.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-03-25 07:51:20 UTC
A commit references this bug:

Author: tobik
Date: Mon Mar 25 07:51:15 UTC 2019
New revision: 496800
URL: https://svnweb.freebsd.org/changeset/ports/496800

Log:
  sysutils/consolekit2: Make ck-system-* scripts user editable

  This might be needed when using alternatives to init(8), like
  sysutils/runit-faster, which do not react well to signals send by
  shutdown(8)/reboot(8) and where you have to use other commands,
  like runit-init {0,6}.  By updating the ck-system-* scripts to run
  them instead, we can actually make use of things like the Xfce4
  logout dialog or Kodi's shutdown dialog with runit-faster.  But to
  make this permanent across updates the scripts have to be installed
  as sample files.

  PR:		236445
  Submitted by:	tobik
  Approved by:	gnome (maintainer timeout, 14 days)

Changes:
  head/sysutils/consolekit2/Makefile
  head/sysutils/consolekit2/pkg-plist