Bug 236507 - [NEW PORT] science/py-Mcstas-Tools: Python based set of tools for the McStas neutron simulation package
Summary: [NEW PORT] science/py-Mcstas-Tools: Python based set of tools for the McStas ...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-13 12:20 UTC by Erik B Knudsen
Modified: 2019-04-11 08:01 UTC (History)
0 users

See Also:


Attachments
svn diff for the new port py-McStas-Tools (4.28 KB, patch)
2019-03-13 12:20 UTC, Erik B Knudsen
erkn: maintainer-approval+
Details | Diff
svn diff for the new port py-McStas-Tools (2.54 KB, patch)
2019-03-14 08:41 UTC, Erik B Knudsen
erkn: maintainer-approval+
Details | Diff
svn diff of the new port py-Mcstas-Tools (9.75 KB, patch)
2019-04-11 08:01 UTC, Erik B Knudsen
erkn: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erik B Knudsen 2019-03-13 12:20:53 UTC
Created attachment 202841 [details]
svn diff for the new port py-McStas-Tools

This port contains a python/qt set of tools for the McStas neutron simulation package. McStas itself is in science/mcstas.

This port is intended the upstream replacement for p5-Mcstas-Tools, but they are expected to coexist for some time (appr. 1yr).

Notes:
- Upstream has split the package in several source-files hence the extra logic in do-install etc.
- Scripts with other back-ends than pyqtgraph exist upstream but are not yet in this port.
Comment 1 Tobias Kortkamp freebsd_committer 2019-03-14 07:15:05 UTC
Comment on attachment 202841 [details]
svn diff for the new port py-McStas-Tools

Wrong patch?  The patch seems to be for p5-Mcstas-Tools.  I do not see anything 
Python related here.
Comment 2 Erik B Knudsen 2019-03-14 08:41:43 UTC
Created attachment 202851 [details]
svn diff for the new port py-McStas-Tools

This is now the correct patch with the python stuff in it.
Comment 3 Erik B Knudsen 2019-03-14 08:43:59 UTC
(In reply to Tobias Kortkamp from comment #1)
Yes indeed - it was the wrong patch. I have now submitted the right one.
Stupid mistake. I am deeply embarrassed. Thanks for noticing.
Comment 4 Tobias Kortkamp freebsd_committer 2019-04-08 17:08:18 UTC
Comment on attachment 202851 [details]
svn diff for the new port py-McStas-Tools

The port looks mostly ok, but the patch is still incomplete and is
missing at least pkg-descr, distinfo.

+USES=		cmake python:3.6+ pyqt:5

There is little reason to have USES=pyqt:5 without USE_PYQT.  What
PyQt components are needed at runtime?

+CMAKE_ARGS=	-Denable_mcstas=1

CMAKE_ON=	enable_mcstas

+	${RLN} -s  ${STAGEDIR}${PREFIX}/mcstas/${PORTVERSION}/bin/${e} ${STAGEDIR}${PREFIX}/bin/${e}

${RLN} uses `install -l rs` under the hood not ln(1), so `-s` is
meaningless.  At the moment install(1) ignores it but better not
add it.
Comment 5 Erik B Knudsen 2019-04-11 07:59:58 UTC
(In reply to Tobias Kortkamp from comment #4)
Thank you for your advice, corrections, and suggestions -  and most of all for your time. I am still a ports amateur.

I have now created yet another diff which 
- includes pkg-descr and distinfo.
- where the Makefile does indeed set USE_PYQT to the things needed
- does not have the -s in the ${RLN}-line

But which retains the "CMAKE_ARGS= -Denable_mcstas=1" line as CMAKE_ON does not work due to an upstream issue. I have reported this upstream, wo it is epxeted to change for the next release.

Thanks again,
Erik
Comment 6 Erik B Knudsen 2019-04-11 08:01:20 UTC
Created attachment 203578 [details]
svn diff of the new port py-Mcstas-Tools