Bug 236587 - dns/dnsdist: fails to build with boost 1.70
Summary: dns/dnsdist: fails to build with boost 1.70
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks: 235956
  Show dependency treegraph
 
Reported: 2019-03-17 05:24 UTC by Jan Beich
Modified: 2019-03-17 11:40 UTC (History)
0 users

See Also:
cpm: maintainer-feedback+


Attachments
patch-dnsdist-fix-boost-1.70 (988 bytes, patch)
2019-03-17 10:56 UTC, Carlos J. Puga Medina
cpm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2019-03-17 05:24:21 UTC
While preparing for Boost upgrade this port failed to build. Can you help to avoid marking it as BROKEN?

$ fetch -qo- 'https://reviews.freebsd.org/D19303?download=true' |
  patch -Efsp0 -d /usr/ports
$ make all deinstall install clean -C/usr/ports/devel/boost-jam
$ make all deinstall install clean -C/usr/ports/devel/boost-libs
$ make -C/usr/ports/dns/dnsdist
[...]
dnsdist-lua-vars.cc:99:61: error: expected unqualified-id
                                       {"BADSIG",   ERCode::BADSIG  },
                                                            ^
/usr/include/sys/signal.h:490:17: note: expanded from macro 'BADSIG'
#define BADSIG          SIG_ERR
                        ^
/usr/include/sys/signal.h:139:18: note: expanded from macro 'SIG_ERR'
#define SIG_ERR         ((__sighandler_t *)-1)
                        ^
1 error generated.
Comment 1 Carlos J. Puga Medina freebsd_committer 2019-03-17 08:44:03 UTC
I'm cooking a patch to fix build with boost 1.70

Thanks for reporting.
Comment 2 Carlos J. Puga Medina freebsd_committer 2019-03-17 10:56:15 UTC
Created attachment 202931 [details]
patch-dnsdist-fix-boost-1.70
Comment 3 Jan Beich freebsd_committer 2019-03-17 11:15:04 UTC
I confirm, it builds fine with boost 1.70 after applying the patch.
Comment 4 commit-hook freebsd_committer 2019-03-17 11:38:18 UTC
A commit references this bug:

Author: cpm
Date: Sun Mar 17 11:38:02 UTC 2019
New revision: 496048
URL: https://svnweb.freebsd.org/changeset/ports/496048

Log:
  dns/dnsdist: unbreak with boost 1.70

  dnsdist-lua-vars.cc:99:61: error: expected unqualified-id
                                         {"BADSIG",   ERCode::BADSIG  },
                                                              ^
  /usr/include/sys/signal.h:490:17: note: expanded from macro 'BADSIG'
  #define BADSIG          SIG_ERR
                          ^
  /usr/include/sys/signal.h:139:18: note: expanded from macro 'SIG_ERR'
  #define SIG_ERR         ((__sighandler_t *)-1)
                          ^

  PR:		236587
  Reported by:	jbeich

Changes:
  head/dns/dnsdist/Makefile
  head/dns/dnsdist/files/patch-dnsdist-lua-vars.cc
Comment 5 Carlos J. Puga Medina freebsd_committer 2019-03-17 11:40:02 UTC
Committed, thanks!