Bug 236640 - devel/t1lib: QA fix - add missing USE_XORG entries
Summary: devel/t1lib: QA fix - add missing USE_XORG entries
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-19 16:12 UTC by John Hein
Modified: 2019-03-19 16:41 UTC (History)
1 user (show)

See Also:
ler: maintainer-feedback+


Attachments
[patch] fix xorgs deps + enable parallel build (4.17 KB, patch)
2019-03-19 16:12 UTC, John Hein
jcfyecrayz: maintainer-approval? (ler)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2019-03-19 16:12:40 UTC
Created attachment 202983 [details]
[patch] fix xorgs deps + enable parallel build

If the X11 is on, xglyph and libt1x directly depend on various X libs.  These dependencies are missing from USE_XORG (noticed by stage-qa).  If any of those missing dependencies are removed, t1lib will break.  Relying on indirect dependencies is insufficient since those dependencies can change on their own.

Fix attached.

Also, while here, tweak a Makefile and enable parallel build - cuts build time by more than half here.

Shuffle some directives for portlint.

QA:
  - poudriere ok (on 11/amd64 4 core host)
  - portlint ok
Comment 1 Larry Rosenman freebsd_committer 2019-03-19 16:40:35 UTC
Committed, Thanks!
Comment 2 commit-hook freebsd_committer 2019-03-19 16:41:04 UTC
A commit references this bug:

Author: ler
Date: Tue Mar 19 16:40:06 UTC 2019
New revision: 496273
URL: https://svnweb.freebsd.org/changeset/ports/496273

Log:
  devel/t1lib: fix dependencies, parallel build.

  If the X11 is on, xglyph and libt1x directly depend on various X libs.
  These dependencies are missing from USE_XORG (noticed by stage-qa).
  If any of those missing dependencies are removed, t1lib will break.
  Relying on indirect dependencies is insufficient since those dependencies can change on their own.

  PR:		236640
  Submitted by:	jcfyecrayz@liamekaens.com

Changes:
  head/devel/t1lib/Makefile
  head/devel/t1lib/files/
  head/devel/t1lib/files/patch-Makefile.in
  head/devel/t1lib/files/patch-lib-Makefile.in