Created attachment 203002 [details] Patch file generated with svn diff LIB_DEPENDS+=libasound.so:audio/alsa-lib
Hi! How did you notice the “missing” library? Did any problem occur because of this?
(In reply to Dries Michiels from comment #1) Hi, > How did you notice the “missing” library? I have set DEVELOPER=YES in /etc/make.conf which, among other things, makes make to run Q/A tests: ====> Running Q/A tests (stage-qa) Error: /usr/local/lib/emby-server/bin/ffmpeg is linked to /usr/local/lib/libasound.so.2 from audio/alsa-lib but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libasound.so:audio/alsa-lib You could also execute "make stage-qa" to run these tests (e.g. without DEVELOPER=YES). > Did any problem occur because of this? No problem occured, because I already had audio/alsa-lib installed (because I have chrome/firefox/gimp-app which depends on audio/alsa-lib). But a problem may occur if one try to install emby-server without having audio/alsa-lib. Moreover, even if no problem occurs now, dependency should be signaled to the FreeBSD port system. After an update of a library, it is sometimes necessary to rebuild all the ports that depends on that library. If such an update of audio/alsa-lib occurs, we would easily get that emby-server needs to be rebuilt.
Interesting that one slipped my QA in Poudriere with the initial patch of updating emby to 4.0.2.0. Thanks.
I am currently executing a testport in poudriere (without the addition).
(In reply to Dries Michiels from comment #3) > Interesting that one slipped my QA in Poudriere with the initial patch of updating emby to 4.0.2.0. Your comment made me understand the problem: because I had audio/alsa-lib installed, the embedded ffmpeg enabled alsa support at configure time. Consequently, the embedded ffmpeg get built and linked to /usr/local/lib/libasound.so.2 which triggered the warning.
I thought the "--disable-autodetect" fixed that but it appears to only work on system libraries. A solution would be to explicitly set all auto detected options to disable in the configure args. These options can be search in the ffmpeg configure script, options which will try auto detection.
We can also explicitly disable options not suitable for server use, like alsa, pulse and the likes.
(In reply to Dries Michiels from comment #6) (In reply to Maxime Gauduin from comment #7) In those cases, we could start to enumerate options that would be useless in emby-server: alsa cdio libdc1394 libjack libpulse libxcb openal opengl (I doubt about opengl being able to accelerate encoding) outdev=xv sdl2 sndio Copy-paste, correct and update as you need if that solution is retained.
Hi Swills! Thank you for grabbing this PR, there should be a patch up in phabricator to fix this together with the update to latest version of this port. Would be awesome if you could get that in the tree! Reference (link to phab review in the PR): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237801
The relevant changes were in PR#237801