Bug 236719 - [PATCH] games/torcs: add libusbhid link to try fix in 13-CURRENT
Summary: [PATCH] games/torcs: add libusbhid link to try fix in 13-CURRENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jan Beich
URL:
Keywords: needs-qa, patch
Depends on:
Blocks: 236141
  Show dependency treegraph
 
Reported: 2019-03-22 18:11 UTC by Thibault Payet
Modified: 2019-03-23 03:10 UTC (History)
0 users

See Also:


Attachments
games/torcs fix (1019 bytes, patch)
2019-03-22 18:11 UTC, Thibault Payet
monwarez: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Payet 2019-03-22 18:11:37 UTC
Created attachment 203048 [details]
games/torcs fix

This patch add a link to usbhid for confscreen (which have jostickconfig option which may use usbhid but does not link with it). 
The issue seems to only appear on 13-CURRENT, since I don't have a jails for 13-CURRENT I can't test it for the moment.
Comment 1 Jan Beich freebsd_committer 2019-03-23 02:55:24 UTC
Still fails. -lplibjs depends on hid_* symbols, so every consumer have to be patched. Given there's no pkg-config file to specify static library dependencies maybe plib should be converted into a shared library.

ld: error: export/lib/libtgfclient.so: undefined reference to hid_end_parse
ld: error: export/lib/libtgfclient.so: undefined reference to hid_get_data
ld: error: export/lib/libtgfclient.so: undefined reference to hid_get_item
ld: error: export/lib/libtgfclient.so: undefined reference to hid_get_report_desc
ld: error: export/lib/libtgfclient.so: undefined reference to hid_report_size
ld: error: export/lib/libtgfclient.so: undefined reference to hid_start_parse
Comment 3 commit-hook freebsd_committer 2019-03-23 03:09:53 UTC
A commit references this bug:

Author: jbeich
Date: Sat Mar 23 03:09:26 UTC 2019
New revision: 496625
URL: https://svnweb.freebsd.org/changeset/ports/496625

Log:
  games/torcs: unbreak --no-allow-shlib-undefined with Gold or LLD 9

  ld: error: export/lib/libconfscreens.so: undefined reference to hid_end_parse
  ld: error: export/lib/libconfscreens.so: undefined reference to hid_get_data
  ld: error: export/lib/libconfscreens.so: undefined reference to hid_get_item
  ld: error: export/lib/libconfscreens.so: undefined reference to hid_get_report_desc
  ld: error: export/lib/libconfscreens.so: undefined reference to hid_report_size
  ld: error: export/lib/libconfscreens.so: undefined reference to hid_start_parse

  ld: error: export/lib/libtgfclient.so: undefined reference to hid_end_parse
  ld: error: export/lib/libtgfclient.so: undefined reference to hid_get_data
  ld: error: export/lib/libtgfclient.so: undefined reference to hid_get_item
  ld: error: export/lib/libtgfclient.so: undefined reference to hid_get_report_desc
  ld: error: export/lib/libtgfclient.so: undefined reference to hid_report_size
  ld: error: export/lib/libtgfclient.so: undefined reference to hid_start_parse

  PR:		236719
  Reported by:	pkg-fallout
  Submitted by:	Thibault Payet (maintainer)

Changes:
  head/games/torcs/files/patch-src_libs_confscreens_Makefile
  head/games/torcs/files/patch-src_libs_tgfclient_Makefile