Bug 236739 - Update net/fping to 4.2
Summary: Update net/fping to 4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/schweikert/fping/r...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-23 19:06 UTC by jharris
Modified: 2019-04-14 11:05 UTC (History)
1 user (show)

See Also:
jharris: maintainer-feedback+


Attachments
patch to update port (813 bytes, patch)
2019-03-23 19:06 UTC, jharris
jharris: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description jharris 2019-03-23 19:06:01 UTC
Created attachment 203073 [details]
patch to update port

Update net/fping to 4.2
Comment 1 jharris 2019-03-23 19:39:32 UTC
NB:  The patch in files is no longer needed.

%rm -rf files/
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2019-04-02 08:18:07 UTC
(In reply to jharris from comment #1)

Thank for the patch and the info. The update is at the moment in the pre-commit review at https://reviews.freebsd.org/D19789 and is ready to land once it's approved.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-14 10:59:48 UTC
A commit references this bug:

Author: kai
Date: Sun Apr 14 10:59:13 UTC 2019
New revision: 498885
URL: https://svnweb.freebsd.org/changeset/ports/498885

Log:
  net/fping: Update to 4.2

  While I'm here:
  * Move options block a bit further down according to the PHB

  Changelog:

  * New option -x / --reachable to check if the number of reachable hosts is
    >= a certain number. Useful for example to implement connectivity-checks
  * Allow decimal numbers for '-t', '-i', '-p', and '-Q'
  * Fix build with --disable-ipv6
  * Fix hang with '-6', with ipv6 kernel module, but not loaded
  * Assume '-6' if the binary is named 'fping6' (this is mostly for special
    embedded-distro use cases, and not meant to be used generally in place of
    compiling IPv6-only binary or using '-6')
  * Get rid of warning "timeout (-t) value larger than period (-p) produces
    unexpected results"

  Also remove patch-configure.ac that no longer applies because the build with
  IPv6 support for FreeBSD has been fixed with 4.1.

  https://github.com/schweikert/fping/releases/tag/v4.2

  PR:		236739
  Submitted by:	Jason Harris (maintainer)
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D19789

Changes:
  head/net/fping/Makefile
  head/net/fping/distinfo
  head/net/fping/files/
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2019-04-14 11:05:20 UTC
Committed, thank you for the patch and sorry when it took a bit longer than usual. 

The IPV6 option should be revised with the next update - according to the changelog of the 4.1 release the issue in non-IPv6 environments seems to be fixed:

https://github.com/schweikert/fping/releases/tag/v4.1
https://github.com/schweikert/fping/issues/118