Bug 236787 - www/qt5-webengine: Support for KDE is disabled due intertwined libnotify references
Summary: www/qt5-webengine: Support for KDE is disabled due intertwined libnotify refe...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL: https://reviews.freebsd.org/D18757#42...
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-25 17:05 UTC by Kai Knoblich
Modified: 2020-01-19 07:55 UTC (History)
3 users (show)

See Also:
rakuco: maintainer-feedback+

Attachments
proxy_config_service_linux.cc (original file / taken from www/qt5-webengine 5.12.1) (54.83 KB, text/plain)
2019-03-25 17:05 UTC, Kai Knoblich 		no flags Details
Patch, that disables KDE support (originally taken from www/chromium, included in www/qt5-webengine 5.12.1) (1.26 KB, patch)
2019-03-25 17:07 UTC, Kai Knoblich 		no flags Details | Diff
Excerpt from build logfile with errors if KDE support is re-enabled (1.79 KB, text/plain)
2019-03-25 17:08 UTC, Kai Knoblich 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2019-03-25 17:05:43 UTC 
Created attachment 203141 [details]
proxy_config_service_linux.cc (original file / taken from www/qt5-webengine 5.12.1)

Hello,

during the pre-commit review for www/qt5-webengine one patch was detected that disables KDE support.

If the support for KDE is re-enabled and only the header file for sys/libinotify.h is excluded then the build fails.
Comment 1 Kai Knoblich freebsd_committer freebsd_triage 2019-03-25 17:07:06 UTC 
Created attachment 203142 [details]
Patch, that disables KDE support (originally taken from www/chromium, included in www/qt5-webengine 5.12.1)
Comment 2 Kai Knoblich freebsd_committer freebsd_triage 2019-03-25 17:08:02 UTC 
Created attachment 203143 [details]
Excerpt from build logfile with errors if KDE support is re-enabled
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2020-01-19 07:55:05 UTC 
Review has been committed.