Bug 236876 - java/openjdk11: fail to build on 12.0 i386 without --disable-dtrace
Summary: java/openjdk11: fail to build on 12.0 i386 without --disable-dtrace
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: i386 Any
: --- Affects Some People
Assignee: Greg Lewis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-29 11:16 UTC by VVD
Modified: 2019-03-30 00:41 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (java)


Attachments
Build failed log (24.37 KB, text/plain)
2019-03-29 11:16 UTC, VVD
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2019-03-29 11:16:41 UTC
Created attachment 203239 [details]
Build failed log

With --disable-dtrace build fine.

One more question to this commit https://svnweb.freebsd.org/ports/head/java/openjdk11/Makefile?r1=497060&r2=497064: why alsa is mandatory dependency now?
I planned to use it on headless vm instead of openjdk8 (not just now, but later for sure).
Comment 1 Greg Lewis freebsd_committer 2019-03-29 14:49:51 UTC
It looks like an obvious fix, but it will take a couple of hours to test.
Comment 2 VVD 2019-03-29 15:07:04 UTC
Do you want to fix build with dtrace or just turn off it for arch i386?
What about add option for DTRACE and for ALSA?
I can make patch if you want - it's obvious patch.
Comment 3 commit-hook freebsd_committer 2019-03-29 15:42:04 UTC
A commit references this bug:

Author: glewis
Date: Fri Mar 29 15:41:07 UTC 2019
New revision: 497156
URL: https://svnweb.freebsd.org/changeset/ports/497156

Log:
  Temporarily disable DTRACE on i386

  PR:		236876

Changes:
  head/java/openjdk11/Makefile
Comment 4 Greg Lewis freebsd_committer 2019-03-29 15:44:55 UTC
I tested a patch to fix the build and it interestingly doesn't seem to be working.  It should just be changing the flags in JvmDtraceObjects.gmk for 32 bit platforms, but that isn't being picked up, so I'm looking into why.

In the meantime I've turned it off for i386.

I'm not interested in returning to the option spaghetti of openjdk8.  If someone wanted to propose a -lite port that was headless and had other features turned off I'd be open to that.  But a large number of options makes it difficult to test and update the port and also creates a lot of different combinations which may interact in unexpected ways.
Comment 5 commit-hook freebsd_committer 2019-03-29 17:06:25 UTC
A commit references this bug:

Author: glewis
Date: Fri Mar 29 17:06:21 UTC 2019
New revision: 497169
URL: https://svnweb.freebsd.org/changeset/ports/497169

Log:
  Fix DTrace support for 32 bit platforms and re-enable it.

  PR:		236876

Changes:
  head/java/openjdk11/Makefile
  head/java/openjdk11/files/patch-make_hotspot_lib_JvmDtraceObjects.gmk
Comment 6 VVD 2019-03-30 00:41:48 UTC
Build without errors now.
Thanks!