Bug 236889 - Add binaries requirement for some lib/atf regression tests
Summary: Add binaries requirement for some lib/atf regression tests
Status: In Progress
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: 12.0-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-29 23:57 UTC by Olivier Cochard
Modified: 2019-06-15 09:30 UTC (History)
1 user (show)

See Also:


Attachments
Preventing tests failure if cc or c++ are missing (875 bytes, patch)
2019-03-29 23:57 UTC, Olivier Cochard
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Cochard freebsd_committer 2019-03-29 23:57:44 UTC
Created attachment 203250 [details]
Preventing tests failure if cc or c++ are missing

Some lib/atf family (atf_c/atf_c++, build_test, check_test and macros_test) require usage of cc or c++.
These tests failed if compiler is not installed.

Notice that for macros_test family, only test case 'use' failed if the compiler is missing, but I didn't find how to check requirements just for this one.
Comment 1 Enji Cooper freebsd_committer 2019-03-30 00:14:52 UTC
(In reply to Olivier Cochard from comment #0)

LGTM! #shipit
Comment 2 commit-hook freebsd_committer 2019-04-04 20:34:37 UTC
A commit references this bug:

Author: olivier
Date: Thu Apr  4 20:34:18 UTC 2019
New revision: 345893
URL: https://svnweb.freebsd.org/changeset/base/345893

Log:
  Add requiered programs (cc and c++) for some lib/atf regression tests

  PR:		236889
  Reviewed by:	ngie
  Approved by:	emaste (on IRC)
  MFC after:	1 month
  Sponsored by:	Netflix

Changes:
  head/lib/atf/libatf-c/tests/Makefile
  head/lib/atf/libatf-c++/tests/Makefile
Comment 3 commit-hook freebsd_committer 2019-06-01 18:26:48 UTC
A commit references this bug:

Author: emaste
Date: Sat Jun  1 18:26:07 UTC 2019
New revision: 348498
URL: https://svnweb.freebsd.org/changeset/base/348498

Log:
  libatf: remove workaround not required after atf >= 0.18 update

  lib/atf/libatf-c/tests/Makefile added the -Wno-duplicate-decl-specifier
  due to an issue with an old version of ATF.  ATF has long since been
  updated to a version with the fix so the workaround is no longer
  necessary.

  Found during review for PR 236889.

  PR:		236889
  MFC after:	2 weeks
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/lib/atf/libatf-c/tests/Makefile
Comment 4 commit-hook freebsd_committer 2019-06-15 09:29:20 UTC
A commit references this bug:

Author: emaste
Date: Sat Jun 15 09:28:48 UTC 2019
New revision: 349052
URL: https://svnweb.freebsd.org/changeset/base/349052

Log:
  MFC r348498: libatf: remove workaround not required after atf >= 0.18 update

  lib/atf/libatf-c/tests/Makefile added the -Wno-duplicate-decl-specifier
  due to an issue with an old version of ATF.  ATF has long since been
  updated to a version with the fix so the workaround is no longer
  necessary.

  Found during review for PR 236889.

  PR:		236889

Changes:
_U  stable/12/
  stable/12/lib/atf/libatf-c/tests/Makefile
Comment 5 commit-hook freebsd_committer 2019-06-15 09:30:24 UTC
A commit references this bug:

Author: emaste
Date: Sat Jun 15 09:30:11 UTC 2019
New revision: 349053
URL: https://svnweb.freebsd.org/changeset/base/349053

Log:
  MFC r348498: libatf: remove workaround not required after atf >= 0.18 update

  lib/atf/libatf-c/tests/Makefile added the -Wno-duplicate-decl-specifier
  due to an issue with an old version of ATF.  ATF has long since been
  updated to a version with the fix so the workaround is no longer
  necessary.

  Found during review for PR 236889.

  PR:		236889

Changes:
_U  stable/11/
  stable/11/lib/atf/libatf-c/tests/Makefile