Bug 236893 - deskutils/spice-gtk: mark MAKE_JOBS_UNSAFE=yes
Summary: deskutils/spice-gtk: mark MAKE_JOBS_UNSAFE=yes
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch, patch-ready
Depends on: 236924
Blocks:
  Show dependency tree / graph
 
Reported: 2019-03-30 10:18 UTC by Matthias Andree
Modified: 2019-04-13 16:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (xxjack12xx)

Attachments
failing build log (135.01 KB, text/plain)
2019-03-30 10:18 UTC, Matthias Andree 		no flags Details
patch to fix the build failure (584 bytes, patch)
2019-03-30 10:20 UTC, Matthias Andree 		mandree: maintainer-approval? (xxjack12xx)
 Details | Diff
svn-diff-spice-gtk-libressl (6.78 KB, patch)
2019-03-30 17:19 UTC, Walter Schwarzenfeld 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2019-03-30 10:18:43 UTC 
Created attachment 203252 [details]
failing build log

deskutils/spice-gtk fails to build, see attachment.

Adding MAKE_JOBS_UNSAFE=yes fixes this, will upload second attachment.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2019-03-30 10:20:16 UTC 
Created attachment 203253 [details]
patch to fix the build failure
Comment 2 Jack 2019-03-30 10:59:34 UTC 
How many threads were used to try to compile this?
Comment 3 Walter Schwarzenfeld freebsd_triage 2019-03-30 12:33:58 UTC 
Btw, I got another error with libressl.

ssl_verify.c:37:29: error: static declaration of 'ASN1_STRING_get0_data' follows non-static declaration
static const unsigned char *ASN1_STRING_get0_data(const ASN1_STRING *asn1)
                            ^
/usr/local/include/openssl/asn1.h:788:22: note: previous declaration is here
const unsigned char *ASN1_STRING_get0_data(const ASN1_STRING *x);
                     ^
1 error generated.
Comment 4 Walter Schwarzenfeld freebsd_triage 2019-03-30 17:19:03 UTC 
Created attachment 203259 [details]
svn-diff-spice-gtk-libressl

Patch only for the libressl error (only tested with libressl).
---
I don't have the "JOBS" error.
---
Found in the build code following (don't know if it matter):
Package spice-client-glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `spice-client-glib-2.0.pc'
to the PKG_CONFIG_PATH environment variable
Package 'spice-client-glib-2.0', required by 'virtual:world', not found
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2019-03-31 10:18:59 UTC 
(In reply to Jack from comment #2)
>= 8 threads. I don't care however the missing file error in my build log is a rather sure sign of desynched build. It's more effort (but often worthwhile) to find the actual missing dependency in the Makefiles and add that.
Comment 6 Matthias Andree freebsd_committer freebsd_triage 2019-03-31 10:22:59 UTC 
Mr. Schwarzenfeld, the LibreSSL issue belongs under https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229044 - which see.
Comment 7 Walter Schwarzenfeld freebsd_triage 2019-03-31 11:43:39 UTC 
Ok, so I was wrong. Thanks!
Comment 8 Walter Schwarzenfeld freebsd_triage 2019-03-31 14:35:11 UTC 
I have tried 0.36 (builds fine with libressl). Update is unproblematic you only have to change the PORT_VERSION and distinfo. Maybe, it helps also with your problem.
Comment 9 Jack 2019-04-01 03:21:37 UTC 
I'll do a clean install and see if I can reproduce.
Comment 10 Jack 2019-04-01 03:38:41 UTC 
Added new bug to upgrade the port

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236924

Seems the new version builds fine with multiple threads.
Comment 11 Matthias Andree freebsd_committer freebsd_triage 2019-04-13 16:43:08 UTC 
yup, indeed