Bug 236911 - www/chromium: fix U2F support
Summary: www/chromium: fix U2F support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-03-31 05:32 UTC by Oleksandr Tymoshenko
Modified: 2019-03-31 20:49 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (chromium)


Attachments
chromium-fix-u2f.patch (8.69 KB, patch)
2019-03-31 05:32 UTC, Oleksandr Tymoshenko
cpm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-03-31 05:32:30 UTC
Created attachment 203271 [details]
chromium-fix-u2f.patch

U2F (ie Yubikeys) support was broken in r489612 when part of the required functionality was removed from services/device/hid/hid_connection_freebsd.cc

Attached patch brings it back and also synchronizes blocking checks API with Linux version of the file.
Comment 1 commit-hook freebsd_committer freebsd_triage 2019-03-31 20:48:02 UTC
A commit references this bug:

Author: cpm
Date: Sun Mar 31 20:47:16 UTC 2019
New revision: 497447
URL: https://svnweb.freebsd.org/changeset/ports/497447

Log:
  www/chromium: fix U2F support

  U2F (ie Yubikeys) support was broken in r489612 when part of the required functionality was removed from services/device/hid/hid_connection_freebsd.cc

  Submitted patch brings it back and also synchronizes blocking checks API with Linux version of the file.

  PR:		236911
  Submitted by:	gonzo

Changes:
  head/www/chromium/Makefile
  head/www/chromium/files/patch-services_device_hid_hid__connection__freebsd.cc
  head/www/chromium/files/patch-services_device_hid_hid__connection__freebsd.h
  head/www/chromium/files/patch-services_device_hid_hid__service__freebsd.cc
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-03-31 20:49:42 UTC
Committed! 

Thanks Oleksandr ;)