Bug 236998 - databases/py-pymssql: Unbreak Python 3 build
Summary: databases/py-pymssql: Unbreak Python 3 build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Craig Leres
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-04-04 01:36 UTC by Craig Leres
Modified: 2019-04-04 19:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ports)


Attachments
patch (1.57 KB, patch)
2019-04-04 01:37 UTC, Craig Leres
leres: maintainer-approval?
Details | Diff
diff for Makefile and distinfo (995 bytes, patch)
2019-04-04 16:11 UTC, Henrik Hudson
ports: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Leres freebsd_committer 2019-04-04 01:36:00 UTC
We found py-pymssql does not build with FLAVOR=py37 due to:

    /usr/local/lib/python3.7/site-packages/Cython/Compiler/Main.py:367: FutureWarning: Cython directive 'language_level' not set, using 2 for now (Py2). This will change in a later release! File: /wrkdirs/usr/ports/databases/py-pymssql/work-py37/pymssql-2.1.3/_mssql.pxd

I don't know if this is the right way to fix this but it does allow builds for py27, py36 and py37.
Comment 1 Craig Leres freebsd_committer 2019-04-04 01:37:51 UTC
Created attachment 203360 [details]
patch
Comment 2 Henrik Hudson 2019-04-04 14:54:28 UTC
Thanks for the patch. It looks like upstream added support in 2.1.4 . I'll get a build of that going, but don't have a MS-SQL server to test against at this time.
Comment 3 Henrik Hudson 2019-04-04 16:11:08 UTC
Makefile and distinfo diff attached. I removed the files/ and patches as they all seem to be handled upstream now. This built for me on 11.2 and 12.0, but I'm still using Python 3.6, so didn't verify the py37 build. Upstream reports it as working for Python 3.7.
Comment 4 Henrik Hudson 2019-04-04 16:11:54 UTC
Created attachment 203381 [details]
diff for Makefile and distinfo
Comment 5 Craig Leres freebsd_committer 2019-04-04 17:06:18 UTC
The 2.1.4 patch builds for me ok (once I removed the the two patches for 2.1.3). I've asked my guy to test the new version and will report back.
Comment 6 Craig Leres freebsd_committer 2019-04-04 19:18:01 UTC
We've verified the new version works. If you'll approve your patch, I will commit it.
Comment 7 commit-hook freebsd_committer 2019-04-04 19:37:42 UTC
A commit references this bug:

Author: leres
Date: Thu Apr  4 19:37:23 UTC 2019
New revision: 497863
URL: https://svnweb.freebsd.org/changeset/ports/497863

Log:
  databases/py-pymssql: Update to 2.1.4 and unbreak Python 3 build.

  PR:		236998
  Submitted by:	Henrik Hudson
  Approved by:	Henrik Hudson (maintainer), ler (mentor, implicit)

Changes:
  head/databases/py-pymssql/Makefile
  head/databases/py-pymssql/distinfo
  head/databases/py-pymssql/files/
Comment 8 Craig Leres freebsd_committer 2019-04-04 19:39:05 UTC
Thanks for your help in resolving this problem!