Bug 237023 - multimedia/xfce4-parole: Fix compiler warnings
Summary: multimedia/xfce4-parole: Fix compiler warnings
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-xfce (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-04 18:01 UTC by Olivier Duchateau
Modified: 2019-07-28 09:17 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+

Attachments
Fix compiler warnings (1.58 KB, patch)
2019-04-04 18:01 UTC, Olivier Duchateau 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Duchateau 2019-04-04 18:01:09 UTC 
Created attachment 203385 [details]
Fix compiler warnings

This patch fixes compiler warnings (especially wrong cast).

See my report, https://bugzilla.xfce.org/show_bug.cgi?id=15260
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2019-04-10 09:37:47 UTC 
Hi,

Since I don't know the gstreamer apis and thus not able to understand the patch, could you better elaborate on what this does and what is the exact warning being addressed?

Also, is this patch submitted upstream? Should it?

Thanks!
Comment 2 Olivier Duchateau 2019-07-27 13:49:57 UTC 
My patch has been merged, and it is available in the latest release 1.0.3 [1].

[1] https://mail.xfce.org/pipermail/xfce-announce/2019-July/000732.html
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2019-07-28 09:17:59 UTC 
(In reply to Olivier Duchateau from comment #2)
> My patch has been merged, and it is available in the latest release 1.0.3
> [1].
> 
> [1] https://mail.xfce.org/pipermail/xfce-announce/2019-July/000732.html

Thanks.

I'm working on the update to the port and will commit once done testing it!