Bug 237034 - games/vegastrike: fix build with GCC-based architectures
Summary: games/vegastrike: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-05 07:50 UTC by Piotr Kubaj
Modified: 2019-04-30 14:19 UTC (History)
1 user (show)

See Also:

Attachments
patch (1.54 KB, patch)
2019-04-06 08:43 UTC, Piotr Kubaj 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-05 07:50:18 UTC 
In src/cmd/unit_collide.h, there is accum_huge struct, which is a pointer. Accessing its contents need to happen with ->, not with ., this fixes build with GCC.

While here, add USES=gl gnome sdl.

Tested on powerpc64 and amd64.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2019-04-06 01:24:42 UTC 
Hmm.  I don't see a patch in there.
Comment 2 Piotr Kubaj freebsd_committer freebsd_triage 2019-04-06 08:43:25 UTC 
Created attachment 203426 [details]
patch

Ah, sorry, it's attached now.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-30 14:19:03 UTC 
A commit references this bug:

Author: pkubaj
Date: Tue Apr 30 14:18:36 UTC 2019
New revision: 500494
URL: https://svnweb.freebsd.org/changeset/ports/500494

Log:
  games/vegastrike: fix build with GCC-based architectures

  Replace . with -> (for accessing a pointer) in src/cmd/unit_collide.h

  PR:		237034
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D20090

Changes:
  head/games/vegastrike/files/patch-src_cmd_unit__collide.h