Bug 237042 - net/librdkafka: enable zstd compression support
Summary: net/librdkafka: enable zstd compression support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Luca Pizzamiglio
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2019-04-05 11:52 UTC by Sergey Akhmatov
Modified: 2019-04-05 19:23 UTC (History)
1 user (show)

See Also:
pizzamig: maintainer-feedback+


Attachments
librdkafka - zstd support (691 bytes, patch)
2019-04-05 11:52 UTC, Sergey Akhmatov
sergey: maintainer-approval? (pizzamig)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey Akhmatov 2019-04-05 11:52:57 UTC
Created attachment 203403 [details]
librdkafka - zstd support

The new feature in librdkafka-1.0.0 release is zstd compression support, but net/librdkafka is built without this feature.

The proposed patch adds new dependency on libzstd to enable it.

QA: Poudriere testport: OK on 11.2 & 12.0

# pkg install kafkacat
kafkacat -X list | grep compression.type
- See zstd in the list
Comment 1 commit-hook freebsd_committer 2019-04-05 19:14:30 UTC
A commit references this bug:

Author: pizzamig
Date: Fri Apr  5 19:13:58 UTC 2019
New revision: 497978
URL: https://svnweb.freebsd.org/changeset/ports/497978

Log:
  net/librdkafka: add zstd compression support

  While I'm here, fix variables order.

  PR:		237042
  Submitted by:	Sergey Akhmatov <sergey@akhmatov.ru>
  Sponsored by:	trivago N.V.

Changes:
  head/net/librdkafka/Makefile
Comment 2 Luca Pizzamiglio freebsd_committer 2019-04-05 19:23:23 UTC
Nice catch and nice patch!
Committed! Thanks