Bug 237079 - [patch] multimedia/mpv: Installing or upgrading mpv spuriously reinstalls py-docutils
Summary: [patch] multimedia/mpv: Installing or upgrading mpv spuriously reinstalls py-...
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2019-04-07 20:07 UTC by Philippe Michel
Modified: 2019-04-08 20:47 UTC (History)
0 users

See Also:
cpm: maintainer-feedback+


Attachments
Suggested patch (837 bytes, patch)
2019-04-07 20:07 UTC, Philippe Michel
cpm: maintainer-approval+
Details | Diff
patch (670 bytes, patch)
2019-04-07 21:57 UTC, Carlos J. Puga Medina
cpm: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Michel 2019-04-07 20:07:27 UTC
Created attachment 203446 [details]
Suggested patch

Installing or upgrading mpv reinstalls py-docutils even if a suitable version is already available :

===>>> The following actions will be taken if you choose to proceed:
        Upgrade mpv-0.29.1_5,1 to mpv-0.29.1_6,1
        Re-install py27-docutils-0.14_3

This is due to the Makefile including lines like :

MANPAGES_BUILD_DEPENDS= rst2man:textproc/py-docutils

but with python using flavors there is no py-docutils installed but a py27-docutils or a py3x- one.

See for instance bug #224030 for the discussion of the same issue in another port.

@bugs triagers : considering that the same issue was fixed in cmake more than one year ago but still exists in mpv and possibly in other ports, would it be possible to escalate this to those who support the ports infrastructure in general and somehow check for this kind of use of python packages at build stage and fix it everywhere it is needed ?
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-04-07 21:57:10 UTC
Created attachment 203454 [details]
patch

Only support default python version for py-docutils.
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-04-07 22:00:28 UTC
(In reply to Carlos J. Puga Medina from comment #1)

Can you try this patch?
Comment 3 Philippe Michel 2019-04-08 20:05:52 UTC
The patch makes no difference, but while trying it I noticed that it is only updates with portmaster that trigger a rebuild of py-docutils. A make in /usr/ports/multimedia/mpv already works with the current Makefile.

Maybe the issue is in fact with portmaster, which is both pickier than the port's Makefile and does not recognize that the py27-docutils already installed really is the py-docutils it wants.
Comment 4 Carlos J. Puga Medina freebsd_committer freebsd_triage 2019-04-08 20:47:55 UTC
(In reply to philippe.michel7 from comment #3)

This issue has been reported, please subscribe to the pr227347.

Thanks for your feedback!