Bug 237152 - math/libnormaliz: fix build with GCC-based architectures
Summary: math/libnormaliz: fix build with GCC-based architectures
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-09 10:40 UTC by Piotr Kubaj
Modified: 2019-04-24 19:46 UTC (History)
2 users (show)

See Also:
salvadore: maintainer-feedback+

Attachments
patch (374 bytes, patch)
2019-04-09 10:40 UTC, Piotr Kubaj 		salvadore: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer freebsd_triage 2019-04-09 10:40:02 UTC 
Created attachment 203534 [details]
patch

Add USES=compiler:c++11-lang to fix build on GCC architectures.

Tested on powerpc64 and amd64.
Comment 1 Lorenzo Salvadore freebsd_committer freebsd_triage 2019-04-09 12:34:47 UTC 
Thanks.

I will test the patch as soon as possible.

When you submit a patch, please remember to set the maintainer approval flag to "?" with the maintainer e-mail: after the maintainer has checked your submission he will set the flag to "+" (approved) or "-" (rejected; of course he would give you a reason). The maintainer-feedback flag is not enough: feedback and approval are two different things.
Thanks.
Comment 2 Lorenzo Salvadore freebsd_committer freebsd_triage 2019-04-24 09:34:15 UTC 
Comment on attachment 203534 [details]
patch

Patch approved. Thanks for your work.
Comment 3 commit-hook freebsd_committer freebsd_triage 2019-04-24 19:43:11 UTC 
A commit references this bug:

Author: pkubaj
Date: Wed Apr 24 19:42:38 UTC 2019
New revision: 499903
URL: https://svnweb.freebsd.org/changeset/ports/499903

Log:
  math/libnormaliz: fix build with GCC-based architectures

  PR:		237152
  Approved by:	tcberner (mentor), phascolarctos@protonmail.ch (maintainer)
  Differential Revision:	https://reviews.freebsd.org/D20039

Changes:
  head/math/libnormaliz/Makefile
Comment 4 Piotr Kubaj freebsd_committer freebsd_triage 2019-04-24 19:46:40 UTC 
Committed, thanks!