Update to 3.2.1
- Change MASTER_SITES from GitHub to CHEESESHOP
Created attachment 203626 [details]
3.0.0 introduced backward incompatible changes. databases/py-redis need to be checked for version/API compatibility
Correction: databases/py-redis *dependent ports* need to be checked for version/API compatibility
After updating TEST_DEPENDS and modifying (do-)test target:
390 passed, 27 skipped, 1 warnings in 20.34 seconds
there's an actual list of ports that have dependencies on databases/py-redis:
databases/py-fakeredis: N/A (noted as "redis" in setup.py)
databases/py-rb: >=2.6 (setup.py)
devel/py-eventlib: >=2.7.1 (requirements.txt)
devel/py-rq: >=2.7.0 (setup.py)
graphics/py-sorl-thumbnail: N/A (noted as "redis" in README and setup.cfg (testenv))
net/py-kombu: >=2.8.0 (extra/requirements/extras/redis.txt)
devel/py-cachecontrol: >=2.10.5 (setup.py)
www/py-django-cacheops: >=2.9.1 (setup.py)
www/py-django-constance: N/A (noted as "redis" in setup.py)
www/py-django-redis: >=2.10.0 (setup.py)
Maybe it helps in the further progress of this PR.
(In reply to Kai Knoblich from comment #5)
It does. This was the big piece of QA that needed to be done, so thank you for helping me Kai. I assume from the list that none were "max pinned" with "<X" versions, is this correct?
That is not to say that they 'wont' fail at runtime given API changes, but evaluating setup.py:*_requires in dependents is the best we can do without test target support in everything.
(In reply to Kubilay Kocak from comment #6)
No problem and your assumption is correct: None of the given dependencies is pinned with "<".
Indeed, there's still the risk that something might fail at runtime.
Small correction for one port:
devel/py-cachecontrol -> www/py-cachecontrol
django-redis is incompatible with redis-py >= 3
Fixed in 4.10.0 (www/py-django-redis is at 4.10.0)
setup.py:*_requires aren't going to be sufficient to guarantee no runtime failures unfortunately. Need to check dependents for updates fixing API compatibility before landing this.
kombu needs >= 4.4.0 update (olgeni)
rb: Needs deprecation or BROKEN with redis > 3.0.0 update (this bug) (sunpoet)
eventlib: eeds deprecation or BROKEN with redis > 3.0.0 update (this bug) (sunpoet)
CC all dependent port maintainers for QA details below...
fakeredis: OK - 3.2.* support added in 1.0.3. 3.0.x in 1.0 (cc rene)
rb: Probably NOT OK - No updates since 20171011 (sunpoet)
eventlib: Probably NOT ok - Port is latest version (0.1.5)> Last release 20131002 (sunpoet)
rq: Requires redis >= 3.0.0 (this bug blocks 237238) (cc skreuzer)
sorl-thumbnail: Probably OK (cc ports@caomhin)
Port is 12.4.1, upstream is 12.5.0 - Appears to test latest
redis (no max pin) in tox.ini
kombu: NOT OK - Upstream is 4.5.0, port is 4.1.0 (cc: olgeni)
Revert celery/kombu#954. Instead bump the required redis-py dependency to 3.2.0 to include this fix andymccurdy/redis-py@4e1e748.
Support both Redis client version 2.x and version 3.x.
cachecontrol: OK - Port is 0.12.5, Upstream is 0.12.5 (cc yuri)
tests latest redis (no max pin), in tox.ini. "redis==3.2.0" from Travis CI log
django-cacheops: Probably OK - Upstream is 4.1, Port is 4.1 (cc kai)
Travis CI tests "redis==3.2.1". Build is failing
django-constance: OK. Upstream is 2.4.0, Port is 2.4.0 (cc ultima)
Travis tests with redis==3.2.1
django-redis: Probably OK Upstream is 4.10.0, Port is 4.10.0 (sunpoet)
- Add support for redis-py 3.0.
tox.ini pins: redis2: redis>=2.10.0,<3.0.0 for one set of envs
Travis Ci build with redis==3.2.1 passes but one failure
There is already a PR for the updating of net/py-kombu. The attached patch needs to be updated.
(In reply to Kai Knoblich from comment #11)
net/py-kombu had been updated to 4.6.3 now.
(In reply to wen from comment #12)
That was quick, many thanks! Maybe that PR can be closed then?
(In reply to Kubilay Kocak from comment #10)
At the moment there are only two ports that need to be handled before databases/py-redis can be updated:
*** Bug 239176 has been marked as a duplicate of this bug. ***